Chromium Code Reviews Chromium Code Reviews
Issue 21690005:
Only submit HomePageIsNewTabPage metric when ShowHomeButton is enabled (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <!-- | 1 <!-- |
| 2 Copyright 2013 The Chromium Authors. All rights reserved. | 2 Copyright 2013 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. | 4 found in the LICENSE file. |
| 5 --> | 5 --> |
| 6 | 6 |
| 7 <!-- | 7 <!-- |
| 8 This file is used to generate a comprehensive list of Chrome histograms along | 8 This file is used to generate a comprehensive list of Chrome histograms along |
| 9 with a detailed description for each histogram. | 9 with a detailed description for each histogram. |
| 10 | 10 |
| (...skipping 13076 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 13087 </summary> | 13087 </summary> |
| 13088 </histogram> | 13088 </histogram> |
| 13089 | 13089 |
| 13090 <histogram name="Search.DefaultSearchProvider" enum="OmniboxSearchEngine"> | 13090 <histogram name="Search.DefaultSearchProvider" enum="OmniboxSearchEngine"> |
| 13091 <summary> | 13091 <summary> |
| 13092 The id of the default search engine that is loaded after Chrome startup. See | 13092 The id of the default search engine that is loaded after Chrome startup. See |
| 13093 src/chrome/browser/search_engines/prepopulate_engines.json for more info. | 13093 src/chrome/browser/search_engines/prepopulate_engines.json for more info. |
| 13094 </summary> | 13094 </summary> |
| 13095 </histogram> | 13095 </histogram> |
| 13096 | 13096 |
| 13097 <histogram name="Settings.GivenShowHomeButton_HomePageIsNewTabPage" | |
| 13098 enum="Boolean"> | |
| 13099 <summary> | |
| 13100 Whether or not the home page user preference is set to the default NTP value | |
| 13101 when a profile is loaded. This is only logged if the Home button is shown. | |
|
Mark P
2013/08/05 22:00:53
nit: lowercase Home please
| |
| 13102 </summary> | |
| 13103 </histogram> | |
| 13104 | |
| 13097 <histogram name="Settings.HomePageIsNewTabPage" enum="Boolean"> | 13105 <histogram name="Settings.HomePageIsNewTabPage" enum="Boolean"> |
| 13106 <obsolete> | |
| 13107 Deprecated 08/05/2013. Replaced by | |
| 13108 Settings.GivenShowHomeButton_HomePageIsNewTabPage. | |
| 13109 </obsolete> | |
| 13098 <summary> | 13110 <summary> |
| 13099 Whether or not the home page user preference is set to the default NTP value | 13111 Whether or not the home page user preference is set to the default NTP value |
| 13100 when a profile is loaded. | 13112 when a profile is loaded. |
| 13101 </summary> | 13113 </summary> |
| 13102 </histogram> | 13114 </histogram> |
| 13103 | 13115 |
| 13104 <histogram name="Settings.ShowHomeButton" enum="BooleanEnabled"> | 13116 <histogram name="Settings.ShowHomeButton" enum="BooleanEnabled"> |
| 13105 <summary> | 13117 <summary> |
| 13106 Whether or not the Home button is enabled in user preferences when a profile | 13118 Whether or not the Home button is enabled in user preferences when a profile |
| 13107 is loaded. | 13119 is loaded. |
| (...skipping 11231 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 24339 <group name="Disabled" label="Neither extra webstore link is visible"/> | 24351 <group name="Disabled" label="Neither extra webstore link is visible"/> |
| 24340 <group name="FooterLink" label="Link in bottom right of footer"/> | 24352 <group name="FooterLink" label="Link in bottom right of footer"/> |
| 24341 <group name="PlusIcon" label="Plus icon in apps page"/> | 24353 <group name="PlusIcon" label="Plus icon in apps page"/> |
| 24342 <affected-histogram name="Extensions.AppLaunch"/> | 24354 <affected-histogram name="Extensions.AppLaunch"/> |
| 24343 <affected-histogram name="NewTabPage.DefaultPageType"/> | 24355 <affected-histogram name="NewTabPage.DefaultPageType"/> |
| 24344 </fieldtrial> | 24356 </fieldtrial> |
| 24345 | 24357 |
| 24346 </fieldtrials> | 24358 </fieldtrials> |
| 24347 | 24359 |
| 24348 </histogram-configuration> | 24360 </histogram-configuration> |
| OLD | NEW |
