Remove obsolete gtest configurations

build/secondary/testing/gtest/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build_overrides/gtest.gni")
 
 config("gtest_config") {
   visibility = [
     ":*",
     "//testing/gmock:*",  # gmock also shares this config.
   ]
 
   defines = [
     # In order to allow regex matches in gtest to be shared between Windows
     # and other systems, we tell gtest to always use it's internal engine.
     "GTEST_HAS_POSIX_RE=0",
 
     # Chrome doesn't support / require C++11, yet.
     "GTEST_LANG_CXX11=0",
   ]
 
   # Gtest headers need to be able to find themselves.
   include_dirs = [ "include" ]
 
   if (is_win) {
     cflags = [ "/wd4800" ]  # Unused variable warning.
   }
-
-  if (is_posix) {
-    defines += [
-      # gtest isn't able to figure out when RTTI is disabled for gcc
-      # versions older than 4.3.2, and assumes it's enabled.  Our Mac

[danakj, 2016/07/21 18:54:58]

I currently have gcc 4.8.4, so that's a long way from 4.3.2. Precise has 4.6.3.
Natty has 4.5.2. Maverick has 4.4.4 and 4.5.1, and support for it ended in 2012.
I think this should be safe to remove then, as according to the comment, gtest
can figure out RTTI now.

One question though, this comment doesn't mention clang. Can gtest tell we have
RTTI disabled on clang?

[tzik, 2016/07/21 19:06:24]

Yes. According to the comment around the feature detection in gtest, it can
detect the availability of RTTI from clang 2.7, that was released in 2010.
https://cs.chromium.org/chromium/src/testing/gtest/include/gtest/internal/gte...

-      # and Linux builds disable RTTI, and cannot guarantee that the
-      # compiler will be 4.3.2. or newer.  The Mac, for example, uses
-      # 4.2.1 as that is the latest available on that platform.  gtest
-      # must be instructed that RTTI is disabled here, and for any
-      # direct dependents that might include gtest headers.
-      "GTEST_HAS_RTTI=0",
-    ]
-  }
-
-  if (is_android) {
-    defines += [
-      # We want gtest features that use tr1::tuple, but we currently
-      # don't support the variadic templates used by libstdc++'s
-      # implementation. gtest supports this scenario by providing its
-      # own implementation but we must opt in to it.
-      "GTEST_USE_OWN_TR1_TUPLE=1",

[danakj, 2016/07/21 18:54:58]

This looks ok to remove, we support variadic templates everywhere.

-
-      # GTEST_USE_OWN_TR1_TUPLE only works if GTEST_HAS_TR1_TUPLE is set.
-      # gtest r625 made it so that GTEST_HAS_TR1_TUPLE is set to 0
-      # automatically on android, so it has to be set explicitly here.
-      "GTEST_HAS_TR1_TUPLE=1",
-    ]
-  }
 }
 
 config("gtest_direct_config") {
   visibility = [ ":*" ]
   defines = [ "UNIT_TEST" ]
 }
 
 config("gtest_warnings") {
   if (is_win && is_clang) {
     # The Mutex constructor initializer list in gtest-port.cc is incorrectly
@@ skipping 85 matching lines @@
 
 source_set("gtest_main") {
   testonly = true
   sources = [
     "src/gtest_main.cc",
   ]
   deps = [
     ":gtest",
   ]
 }