Disables the context menu in User Manager's reauth dialog

chrome/browser/ui/user_manager.h

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_USER_MANAGER_H_
 #define CHROME_BROWSER_UI_USER_MANAGER_H_
 
 #include "base/callback_forward.h"
 #include "base/macros.h"
 #include "chrome/browser/profiles/profile_window.h"
 #include "components/signin/core/browser/signin_metrics.h"
+#include "content/public/browser/web_contents_delegate.h"
 
 namespace base {
 class FilePath;
 }
 
 // Cross-platform methods for displaying the user manager.
 class UserManager {
  public:
   // Shows the User Manager or re-activates an existing one, focusing the
   // profile given by |profile_path_to_focus|; passing an empty base::FilePath
@@ skipping 40 matching lines @@
   // Dimensions of the reauth dialog displaying the old-style signin flow with
   // the username and password challenge on the same form.
   static const int kPasswordCombinedReauthDialogHeight = 440;
   static const int kPasswordCombinedReauthDialogWidth = 360;
 
   // Dimensions of the reauth dialog displaying the password-separated signin
   // flow.
   static const int kReauthDialogHeight = 512;
   static const int kReauthDialogWidth =  448;
 
-  // This class observes the WebUI used in the UserManager to perform online
-  // reauthentication of locked profiles. It is concretely implemented in
-  // UserManagerMac and UserManagerView to specialize the closing of the UI's
-  // dialog widget.
-  class ReauthDialogObserver : public content::WebContentsObserver {
+  // Abstract base class for performing online reauthentication of profiles in
+  // the User Manager. It is concretely implemented in UserManagerMac and
+  // UserManagerView to specialize the closing of the UI's dialog widgets.
+  class BaseReauthDialogDelegate : virtual public content::WebContentsDelegate {

[sky, 2016/07/21 19:19:58]

multiple inheritance is frowned upon, and diamond inheritance more so. Please
restructure things so you aren't inheriting from a bunch of non-virtual classes.

    public:
-    ReauthDialogObserver(content::WebContents* web_contents,
-                         const std::string& email_address);
+    explicit BaseReauthDialogDelegate(content::WebContents* web_contents);
+
+    // content::WebContentsDelegate:
+    bool HandleContextMenu(const content::ContextMenuParams& params) override;
+
+    // content::WebContentsDelegate:
+    void LoadingStateChanged(content::WebContents* source,
+                             bool to_different_document) override;
 
    private:
-    // content::WebContentsObserver:
-    void DidStopLoading() override;
-
     virtual void CloseReauthDialog() = 0;
 
-    const std::string email_address_;
+    content::WebContents* web_contents_;
 
-    DISALLOW_COPY_AND_ASSIGN(ReauthDialogObserver);
+    DISALLOW_COPY_AND_ASSIGN(BaseReauthDialogDelegate);
   };
 
  private:
   DISALLOW_COPY_AND_ASSIGN(UserManager);
 };
 
 #endif  // CHROME_BROWSER_UI_USER_MANAGER_H_