Issue 216893005: Mojo: Move the handle table details out of CoreImpl into its own class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216893005: Mojo: Move the handle table details out of CoreImpl into its own class. (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Mojo: Move the handle table details out of CoreImpl into its own class. (This will make it much easier to improve the handle table, e.g., by caching handle look-ups.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260482

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+451 lines, -217 lines)			Patch
M	mojo/embedder/test_embedder.cc	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	mojo/mojo.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/system/core_impl.h	View		3 chunks	+3 lines, -16 lines	0 comments	Download
M	mojo/system/core_impl.cc	View		11 chunks	+63 lines, -190 lines	0 comments	Download
M	mojo/system/dispatcher.h	View		4 chunks	+7 lines, -5 lines	0 comments	Download
M	mojo/system/dispatcher.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	mojo/system/handle_table.h	View		1 chunk	+126 lines, -0 lines	0 comments	Download
A	mojo/system/handle_table.cc	View	1	1 chunk	+240 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

darin (slow to review)

LGTM Seems like a nice unit of code to factor out regardless of future changes.

6 years, 8 months ago (2014-03-30 17:04:14 UTC) #2

viettrungluu

6 years, 8 months ago (2014-03-31 02:07:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r260482 (presubmit successful).