Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2168903002: Set request context when restoring cached CSSImageValue resource (Closed)

Created:
4 years, 5 months ago by petrcermak
Modified:
4 years, 5 months ago
Reviewers:
haraken, Mike West
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set request context when restoring cached CSSImageValue resource This patch changes the resource context type of the FetchRequest issued in CSSImageValue::restoreCachedResourceIfNeeded from WebURLRequest::RequestContextUnspecified to WebURLRequest::RequestContextImage. BUG=630215 Committed: https://crrev.com/f9d060c269818531e9fcf3f5ecf889c570f3d5c8 Cr-Commit-Position: refs/heads/master@{#406846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
A + third_party/WebKit/LayoutTests/http/tests/css/image-value-cached.html View 1 chunk +8 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/css/resources/image-value-cached-iframe.html View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/css/resources/image-value-via-https.css View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 5 months ago (2016-07-21 13:21:35 UTC) #2
petrcermak
Kentaro: Could you please take a look (since Mike is OOO)? Note that this patch ...
4 years, 5 months ago (2016-07-21 14:16:38 UTC) #6
haraken
LGTM
4 years, 5 months ago (2016-07-21 14:33:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168903002/1
4 years, 5 months ago (2016-07-21 14:35:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 14:39:18 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 14:40:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9d060c269818531e9fcf3f5ecf889c570f3d5c8
Cr-Commit-Position: refs/heads/master@{#406846}

Powered by Google App Engine
This is Rietveld 408576698