Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/debug/debug.cc

Issue 2168883002: [debugger] remove obsolete work-around for return position. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index 00f1c793338010166a9d63a27d6a05db2ca320be..4d0ca16b213777dba58b47174a9c11bbd6889257 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -80,19 +80,7 @@ BreakLocation::BreakLocation(Handle<DebugInfo> debug_info, DebugBreakType type,
code_offset_(code_offset),
type_(type),
position_(position),
- statement_position_(statement_position) {
- if (type == DEBUG_BREAK_SLOT_AT_RETURN) {
- int return_position = 0;
- SharedFunctionInfo* shared = debug_info->shared();
- if (shared->HasSourceCode()) {
- return_position =
- std::max(shared->end_position() - 1, shared->start_position());
- }
- // TODO(yangguo): find out why return position is wrong for liveedit.
- position_ = return_position;
- statement_position_ = return_position;
- }
-}
+ statement_position_(statement_position) {}
BreakLocation::Iterator* BreakLocation::GetIterator(
Handle<DebugInfo> debug_info, BreakLocatorType type) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698