Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm

Issue 2168853003: Mac Picker UI: Screen Auto Selection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unittest Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
diff --git a/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm b/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
index e2858cdd61e6293af69d41a920ae64b9e74b018f..05c6cb3f950b773dbc54b2e84b56ad6cb5141ce1 100644
--- a/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
+++ b/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
@@ -597,7 +597,14 @@ NSString* const kTitleId = @"title";
- (id)imageBrowser:(IKImageBrowserView*)browser itemAtIndex:(NSUInteger)index {
DesktopMediaID::Type sourceType = [self sourceTypeForBrowser:browser];
NSMutableArray* items = [self itemSetForType:sourceType];
- return [items objectAtIndex:index];
+ DesktopMediaPickerItem* item = [items objectAtIndex:index];
+
+ // For screen source, if there is only one source, we can omit the label
+ // "Entire Screen", because it is redundant with tab label "Your Entire
+ // Screen".
+ [item setTitleHidden:browser == screenBrowser_ && [items count] == 1];
+
+ return item;
}
#pragma mark IKImageBrowserDelegate
@@ -681,10 +688,17 @@ NSString* const kTitleId = @"title";
[[DesktopMediaPickerItem alloc] initWithSourceId:source.id
imageUID:++lastImageUID_
imageTitle:imageTitle]);
+
[items insertObject:item atIndex:index];
[browser reloadData];
- if (sourceType == DesktopMediaID::TYPE_WEB_CONTENTS)
+ if (sourceType == DesktopMediaID::TYPE_WEB_CONTENTS) {
+ // Memorizing selection.
[self setTabBrowserIndex:selectedIndex];
+ } else if (sourceType == DesktopMediaID::TYPE_SCREEN && [items count] == 1) {
+ // Preselect the first screen source.
+ [browser setSelectionIndexes:[NSIndexSet indexSetWithIndex:0]
+ byExtendingSelection:NO];
+ }
NSString* autoselectSource = base::SysUTF8ToNSString(
base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698