[Turbofan] Fix a race on CallInterfaceDescriptor initialization.

[Turbofan] Fix a race on CallInterfaceDescriptor initialization.

The effect control linearizer runs off-thread and needs the ToNumber
call descriptor. Add a hack to create this on the main thread to
ensure off-thread's don't race on it's construction. Also add a
DCHEK to the CallInterfaceDescriptor to ensure they are always
initilaized on the main thread.

Committed: https://crrev.com/1df29e190f8a3ecda77b794430d3f7a1f39af866
Cr-Commit-Position: refs/heads/master@{#37973}

[rmcilroy, 2016-07-21 13:44:51]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 13:45:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-07-21 13:45:37]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2016-07-21 13:45:37]

Michi please review.

Benedikt for FYI (comments welcome).

[commit-bot: I haz the power, 2016-07-21 14:07:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 14:07:41]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-07-21 16:36:47]

LGTM.

https://codereview.chromium.org/2168843003/diff/1/src/interface-descriptors.h
File src/interface-descriptors.h (right):

https://codereview.chromium.org/2168843003/diff/1/src/interface-descriptors.h...
src/interface-descriptors.h:220:
CHECK(ThreadId::Current().Equals(isolate->thread_id()));
nit: DCHECK should do it.

[rmcilroy, 2016-07-22 09:16:26]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-07-22 09:16:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2168843003/#ps20001
(title: "DCHECK")

[rmcilroy, 2016-07-22 09:16:32]

https://codereview.chromium.org/2168843003/diff/1/src/interface-descriptors.h
File src/interface-descriptors.h (right):

https://codereview.chromium.org/2168843003/diff/1/src/interface-descriptors.h...
src/interface-descriptors.h:220:
CHECK(ThreadId::Current().Equals(isolate->thread_id()));
On 2016/07/21 16:36:47, Michael Starzinger wrote:
> nit: DCHECK should do it.

Yes sorry, thats what I original had then while testing on tsan release I wanted
to check it actually worked and forgot to change it back. Done.

[commit-bot: I haz the power, 2016-07-22 09:16:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 09:39:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 09:42:43]

Description was changed from

==========
[Turbofan] Fix a race on CallInterfaceDescriptor initialization.

The effect control linearizer runs off-thread and needs the ToNumber
call descriptor. Add a hack to create this on the main thread to
ensure off-thread's don't race on it's construction. Also add a
DCHEK to the CallInterfaceDescriptor to ensure they are always
initilaized on the main thread.
==========

to

==========
[Turbofan] Fix a race on CallInterfaceDescriptor initialization.

The effect control linearizer runs off-thread and needs the ToNumber
call descriptor. Add a hack to create this on the main thread to
ensure off-thread's don't race on it's construction. Also add a
DCHEK to the CallInterfaceDescriptor to ensure they are always
initilaized on the main thread.

Committed: https://crrev.com/1df29e190f8a3ecda77b794430d3f7a1f39af866
Cr-Commit-Position: refs/heads/master@{#37973}
==========

[commit-bot: I haz the power, 2016-07-22 09:42:44]

Patchset 2 (id:??) landed as
https://crrev.com/1df29e190f8a3ecda77b794430d3f7a1f39af866
Cr-Commit-Position: refs/heads/master@{#37973}