Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 2168833003: Support references to operators in doc comments (issue 26929) (Closed)

Created:
4 years, 5 months ago by Brian Wilkerson
Modified:
4 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +42 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/element_resolver_test.dart View 1 chunk +19 lines, -0 lines 2 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 5 months ago (2016-07-21 14:47:47 UTC) #2
scheglov
LGTM Are we able to resolve these new references? It would be nice to have ...
4 years, 5 months ago (2016-07-21 15:38:13 UTC) #3
Brian Wilkerson
> It would be nice to have corresponding tests. I thought the test in element_resolver_test.dart ...
4 years, 5 months ago (2016-07-21 15:43:44 UTC) #4
Brian Wilkerson
4 years, 5 months ago (2016-07-21 16:12:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5cb949e5133f0d14fc3d805415b24557079feb6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698