Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2168763003: Re-enable back-to-redirect-with-frame test for --site-per-process. (Closed)

Created:
4 years, 5 months ago by Charlie Reis
Modified:
4 years, 5 months ago
Reviewers:
Łukasz Anforowicz
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable back-to-redirect-with-frame test for --site-per-process. This was fixed in r406861. BUG=585194 TEST=webkit_tests on Site Isolation Linux FYI bot Committed: https://crrev.com/0e6a2a2aea6692a191326995401710bcad7a015b Cr-Commit-Position: refs/heads/master@{#406901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Charlie Reis
I forgot to enable this in r406861. Can you review?
4 years, 5 months ago (2016-07-21 16:51:10 UTC) #4
Łukasz Anforowicz
Thanks for helping minimize the amount of test exceptions. LGTM assuming the test passes (note1: ...
4 years, 5 months ago (2016-07-21 17:02:27 UTC) #5
Charlie Reis
On 2016/07/21 17:02:27, Łukasz Anforowicz wrote: > Thanks for helping minimize the amount of test ...
4 years, 5 months ago (2016-07-21 17:20:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168763003/1
4 years, 5 months ago (2016-07-21 17:21:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 18:06:09 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:09:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e6a2a2aea6692a191326995401710bcad7a015b
Cr-Commit-Position: refs/heads/master@{#406901}

Powered by Google App Engine
This is Rietveld 408576698