tools/perf/page_sets/login_helpers/facebook_login.py - Issue 2168743004: [system health] Add media browsing stories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/login_helpers/facebook_login.py

Issue 2168743004: [system health] Add media browsing stories. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: disable facebook on desktop Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/login_helpers/facebook_login.py

diff --git a/tools/perf/page_sets/login_helpers/facebook_login.py b/tools/perf/page_sets/login_helpers/facebook_login.py

index 360cf28da6f7f6fdaa77f10ba8b2c04a3ab068cf..a07ddff40d22b5c2c59bb01a46af141d0ab57bf1 100644

--- a/tools/perf/page_sets/login_helpers/facebook_login.py

+++ b/tools/perf/page_sets/login_helpers/facebook_login.py

@@ -33,3 +33,11 @@ def LoginWithMobileSite(

action_runner.WaitForElement(text='OK')

action_runner.ClickElement(text='OK')

action_runner.WaitForNavigate()

+def LoginWithDesktopSite(

+ action_runner, credential,

+ credentials_path=login_utils.DEFAULT_CREDENTIAL_PATH):

+ # Currently we use the mobile login page also on Desktop because the

+ # Desktop version requires enabled cookies and rejects the login.

+ return LoginWithMobileSite(action_runner, credential, credentials_path)