[system health] Add media browsing stories.

tools/perf/page_sets/system_health/browsing_stories.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+from page_sets.login_helpers import facebook_login
 from page_sets.system_health import platforms
 from page_sets.system_health import system_health_story
 
 
 class _BrowsingStory(system_health_story.SystemHealthStory):
   """Abstract base class for browsing stories.
 
   A browsing story visits items on the main page. Subclasses provide
   CSS selector to identify the items and implement interaction using
   the helper methods of this class.
   """
 
   IS_SINGLE_PAGE_APP = False
   ITEM_SELECTOR = NotImplemented
   ITEMS_TO_VISIT = 4

[petrcermak, 2016/08/01 11:22:30]

This field is currently not used anywhere in the base class. Either move it to
_NewsBrowsingStory (_MediaBrowsingStory overrides it anyway), or add an abstract
_ViewItem method:

class _BrowsingStory:

  def _DidLoadDocument(self, action_runner):
    for i in xrange(self.ITEMS_TO_VISIT):
      self._ViewItem(action_runner, i)

  def _ViewItem(self, action_runner, index):
    raise NotImplementedError


class _NewsBrowsingStory:
  def _ViewItem(self, action_runner, index):
    ...


class _MediaBrowsingStory:
  def _ViewItem(self, action_runner, index):
    ...

[Hannes Payer (out of office), 2016/08/04 11:38:01]

Moved it to the _NewsBrowsingStory.

   ABSTRACT_STORY = True
 
   def _WaitForNavigation(self, action_runner):
     if not self.IS_SINGLE_PAGE_APP:
       action_runner.WaitForNavigate()
 
   def _NavigateToItem(self, action_runner, index):
     item_selector = 'document.querySelectorAll("%s")[%d]' % (
         self.ITEM_SELECTOR, index)
     self._ClickLink(action_runner, item_selector)
 
   def _ClickLink(self, action_runner, element_function):
     action_runner.WaitForElement(element_function=element_function)
     action_runner.ClickElement(element_function=element_function)
     self._WaitForNavigation(action_runner)
 
   def _NavigateBack(self, action_runner):
     action_runner.ExecuteJavaScript('window.history.back()')
     self._WaitForNavigation(action_runner)
 
 
+##############################################################################
+# News browsing stories.
+##############################################################################
+
+
 class _NewsBrowsingStory(_BrowsingStory):
   """Abstract base class for news user stories.
 
   A news story imitates browsing a news website:
   1. Load the main page.
   2. Open and scroll the first news item.
   3. Go back to the main page and scroll it.
   4. Open and scroll the second news item.
   5. Go back to the main page and scroll it.
   6. etc.
@@ skipping 16 matching lines @@
     action_runner.Wait(self.ITEM_READ_TIME_IN_SECONDS)
     action_runner.RepeatableBrowserDrivenScroll(
         repeat_count=self.ITEM_SCROLL_REPEAT)
 
   def _ScrollMainPage(self, action_runner):
     action_runner.tab.WaitForDocumentReadyStateToBeComplete()
     action_runner.RepeatableBrowserDrivenScroll(
         repeat_count=self.MAIN_PAGE_SCROLL_REPEAT)
 
 
-##############################################################################
-# News browsing stories.
-##############################################################################
-
-
 class CnnStory(_NewsBrowsingStory):
   """The second top website in http://www.alexa.com/topsites/category/News"""
   NAME = 'browse:news:cnn'
   URL = 'http://edition.cnn.com/'
   ITEM_SELECTOR = '.cd__content > h3 > a'
   ITEMS_TO_VISIT = 2
   # TODO(ulan): Enable this story on mobile once it uses less memory and
   # does not crash with OOM.
   SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
 
@@ skipping 113 matching lines @@
   def _DidLoadDocument(self, action_runner):
     # Close the popup window. On Nexus 9 (and probably other tables) the popup
     # window does not have a "Close" button, instead it has only a "Send link
     # to phone" button. So on tablets we run with the popup window open. The
     # popup is transparent, so this is mostly an aesthetical issue.
     has_button = action_runner.EvaluateJavaScript(
         '!!document.querySelector("%s")' % self._CLOSE_BUTTON_SELECTOR)
     if has_button:
       action_runner.ClickElement(selector=self._CLOSE_BUTTON_SELECTOR)
     super(WashingtonPostMobileStory, self)._DidLoadDocument(action_runner)
+
+
+##############################################################################
+# Media browsing stories.

[petrcermak, 2016/08/01 11:22:30]

Can you please update the corresponding loading stories (which you might need to
add) to have the same URLs (+logins if applicable) as the ones you use here?

[Hannes Payer (out of office), 2016/08/04 11:38:01]

Added imgur to the load stories.
Changed the links in the browsing stories to be the same as in the load stories.
Done.

+##############################################################################
+
+
+class _MediaBrowsingStory(_BrowsingStory):
+  """ Abstract base class for media user stories

[petrcermak, 2016/08/01 11:22:30]

nit: remove space before "Abstract"

[Hannes Payer (out of office), 2016/08/04 11:38:01]

Done.

+
+  A media story imitates browsing a website with photo or video content:
+  1. Load a page showing a media item
+  2. Click on the next link to go to the next media item
+  3. etc.
+  """
+
+  ABSTRACT_STORY = True
+  ITEM_VIEW_TIME_IN_SECONDS = 1
+  ITEMS_TO_VISIT = 30
+  ITEM_SELECTOR_INDEX = 0
+
+  def _DidLoadDocument(self, action_runner):
+    for _ in xrange(self.ITEMS_TO_VISIT):
+      self._NavigateToItem(action_runner, self.ITEM_SELECTOR_INDEX)
+      self._ViewMediaItem(action_runner)
+
+  def _ViewMediaItem(self, action_runner):
+    action_runner.tab.WaitForDocumentReadyStateToBeComplete()
+    action_runner.Wait(self.ITEM_VIEW_TIME_IN_SECONDS)
+
+
+class ImgurMobileStory(_MediaBrowsingStory):
+  NAME = 'browse:media:imgur'
+  URL = 'http://imgur.com/gallery/5UlBN'
+  ITEM_SELECTOR = '.Navbar-customAction'
+  SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
+  IS_SINGLE_PAGE_APP = True
+
+
+class ImgurDesktopStory(_MediaBrowsingStory):
+  NAME = 'browse:media:imgur'
+  URL = 'http://imgur.com/gallery/5UlBN'
+  ITEM_SELECTOR = '.navNext'
+  SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
+  IS_SINGLE_PAGE_APP = True
+
+
+class YoutubeMobileStory(_MediaBrowsingStory):
+  NAME = 'browse:media:youtube'
+  URL = 'https://m.youtube.com/watch?v=njCDZWTI-xg'
+  ITEM_SELECTOR = '._mpfb > a'
+  IS_SINGLE_PAGE_APP = True
+  SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
+  ITEM_VIEW_TIME_IN_SECONDS = 2
+  ITEMS_TO_VISIT = 15
+  ITEM_SELECTOR_INDEX = 3
+
+
+class YoutubeDesktopStory(_MediaBrowsingStory):
+  NAME = 'browse:media:youtube'
+  URL = 'https://www.youtube.com/watch?v=Ic07xTJoP34'
+  ITEM_SELECTOR = '.yt-uix-simple-thumb-related'
+  SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
+  IS_SINGLE_PAGE_APP = True
+  ITEM_VIEW_TIME_IN_SECONDS = 2

[charliea (OOO until 10-5), 2016/07/29 20:10:01]

IMO this (and the corresponding mobile story time) should be longer: when I ran
these locally (on a fiber connection), there was barely enough time for the
video to load before we moved on to the next story. What about increasing the
time to something like 10 seconds, but cutting the number of pages to something
like 1/3 of what it currently is? That seems like it would more accurately
reproduce how people use YouTube.

[Hannes Payer (out of office), 2016/08/04 11:38:01]

Done.

+  ITEMS_TO_VISIT = 15
+
+
+class FacebookMobileStory(_MediaBrowsingStory):
+  NAME = 'browse:media:facebookphotos'
+  URL = (
+      'https://facebook.com/photo.php?fbid=10154398154450513&id=255110695512&set=a.406278500512.172778.255110695512&source=54&refid=13')
+  ITEM_SELECTOR = '._57-p > a'
+  IS_SINGLE_PAGE_APP = True
+  SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
+  ITEM_VIEW_TIME_IN_SECONDS = 2
+  ITEMS_TO_VISIT = 20
+  ITEM_SELECTOR_INDEX = 1
+
+
+class FacebookDesktopStory(_MediaBrowsingStory):
+  NAME = 'browse:media:facebookphotos'
+  URL = (
+      'https://www.facebook.com/NASA/photos/a.67899501771.69169.54971236771/10154267233981772/?type=3&theater')
+  ITEM_SELECTOR = '.snowliftPager.next'
+  IS_SINGLE_PAGE_APP = True
+  SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
+  ITEM_VIEW_TIME_IN_SECONDS = 2
+  ITEMS_TO_VISIT = 20
+
+  def _Login(self, action_runner):
+    facebook_login.LoginWithDesktopSite(action_runner, 'facebook3',
+                                self.credentials_path)

[petrcermak, 2016/08/01 11:22:30]

nit: invalid indentation. The two basic options are:

  # Line break when needed + vertical alignment.
  facebook_login.LoginWithDesktopSite(action_runner, 'facebook3',
                                      self.credentials_path)

  # Immediate line break + 4 space indent.
  facebook_login.LoginWithDesktopSite(
      action_runner, 'facebook3', self.credentials_path)