Fix the courgette64 copy rules.

Fix the courgette64 copy rules.

I think that I should use courgette64.* but I'm not sure if the copy rule
support wildcards.

BUG=629243
Committed: https://crrev.com/8541a4dac68cbf1fc224c10fbdeb14847414fb78
Cr-Commit-Position: refs/heads/master@{#406710}

[Sébastien Marchand, 2016-07-20 22:07:06]

sebmarchand@chromium.org changed reviewers:
+ dpranke@chromium.org, wfh@chromium.org

[Sébastien Marchand, 2016-07-20 22:07:06]

PTAL (http://i3.kym-cdn.com/photos/images/original/000/234/739/fa5.jpg)

[Dirk Pranke, 2016-07-20 22:13:49]

LGTM; I believe this will accomplish what we want (courgette.exe and
courgette64.exe side-by-side in the root_build_dir).

[Will Harris, 2016-07-20 22:23:31]

https://codereview.chromium.org/2168743002/diff/1/courgette/BUILD.gn
File courgette/BUILD.gn (right):

https://codereview.chromium.org/2168743002/diff/1/courgette/BUILD.gn#newcode133
courgette/BUILD.gn:133: "$root_out_dir/x64/courgette64.exe",
where is this file emitted from?

[Dirk Pranke, 2016-07-20 22:37:41]

https://codereview.chromium.org/2168743002/diff/1/courgette/BUILD.gn
File courgette/BUILD.gn (right):

https://codereview.chromium.org/2168743002/diff/1/courgette/BUILD.gn#newcode133
courgette/BUILD.gn:133: "$root_out_dir/x64/courgette64.exe",
On 2016/07/20 22:23:30, Will Harris wrote:
> where is this file emitted from?

The :courgette(//build/toolchain/win:x64) dependency on line 139 produces that
file.

You could perhaps make this clearer by writing:

  _courgette64 = ":courgette(//build/toolchain/win:x64)"

  sources = get_target_outputs(_courgette64)
  deps = [ _courgette64 ]

[Will Harris, 2016-07-20 22:39:25]

this gn-fu is beyond my expertise so I defer to dpranke, but lgtm for courgette/

[Dirk Pranke, 2016-07-20 22:41:18]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-07-20 22:41:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:35:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-20 23:38:49]

Description was changed from

==========
Fix the courgette64 copy rules.

I think that I should use courgette64.* but I'm not sure if the copy rule
support wildcards.

BUG=629243
==========

to

==========
Fix the courgette64 copy rules.

I think that I should use courgette64.* but I'm not sure if the copy rule
support wildcards.

BUG=629243

Committed: https://crrev.com/8541a4dac68cbf1fc224c10fbdeb14847414fb78
Cr-Commit-Position: refs/heads/master@{#406710}
==========

[commit-bot: I haz the power, 2016-07-20 23:38:50]

Patchset 1 (id:??) landed as
https://crrev.com/8541a4dac68cbf1fc224c10fbdeb14847414fb78
Cr-Commit-Position: refs/heads/master@{#406710}