Issue 216873002: [Android WebView] Fix AwSettingsTest.testUseWideViewportControlsDoubleTabToZoom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216873002: [Android WebView] Fix AwSettingsTest.testUseWideViewportControlsDoubleTabToZoom (Closed)

Created:
6 years, 9 months ago by mnaganov (inactive)

Modified:
6 years, 9 months ago

Reviewers:
mkosiba (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android WebView] Fix AwSettingsTest.testUseWideViewportControlsDoubleTabToZoom The test wasn't working properly on tablets in landscape mode because double tap was effectively zooming in instead of zooming out. To fix that, the page layout has been updated take display width into account. BUG=357235 R=mkosiba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260146

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java	View		1 chunk	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

The CQ bit was checked by mnaganov@chromium.org

6 years, 9 months ago (2014-03-28 13:49:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/216873002/1

6 years, 9 months ago (2014-03-28 13:50:38 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-28 14:35:53 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel

6 years, 9 months ago (2014-03-28 14:35:53 UTC) #6

mnaganov (inactive)

6 years, 9 months ago (2014-03-28 16:09:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r260146 (presubmit successful).

Expand Messages | Collapse Messages