|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by Dirk Pranke Modified:
4 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_mac_perf Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip the last Mac GYP bots to GN (the ASAN bots):
This flips the remaining Mac builders to GN. A number of
browser_tests that use NaCl are failing under ASAN, so
we disable NaCl for now.
This affects:
- chromium.fyi
- ClangToTMacASan
- chromium.lkgr
- Mac ASAN Debug
- Mac ASAN Release Media
- Mac ASAN Release
- chromium.memory:
- Mac ASAN 64 Builder
- tryserver.chromium.mac:
- mac_chromium_asan_rel_ng
TBR=rsesek@chromium.org, brettw@chromium.org, jyasskin@chromium.org
BUG=618468, 630322, 632059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
Committed: https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5
Cr-Commit-Position: refs/heads/master@{#408345}
Patch Set 1 #Patch Set 2 : merge #Patch Set 3 : disable nacl and try again #Patch Set 4 : disable chrome_service_worker_browsertest.cc when nacl is disabled #
Messages
Total messages: 26 (14 generated)
This won't work yet (https://bugs.chromium.org/p/chromium/issues/detail?id=630322).
On 2016/07/21 16:37:59, Robert Sesek wrote: > This won't work yet > (https://bugs.chromium.org/p/chromium/issues/detail?id=630322). Ack, will wait for a fix.
Description was changed from ========== Flip the last set of Mac builders to GN. This flips the last few Mac builders, on the LKGR waterfall, to GN: - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release R=rsesek@chromium.org BUG=618468 ========== to ========== Flip the last Mac GYP bots to GN (the ASAN bots): - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng R=rsesek@chromium.org BUG=618468, 630322 ==========
Description was changed from ========== Flip the last Mac GYP bots to GN (the ASAN bots): - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng R=rsesek@chromium.org BUG=618468, 630322 ========== to ========== Flip the last Mac GYP bots to GN (the ASAN bots): This flips the remaining Mac builders to GN. A number of browser_tests that use NaCl are failing under ASAN, so we disable NaCl for now. This affects: - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng TBR=rsesek@chromium.org BUG=618468, 630322, 632059 ==========
The CQ bit was checked by dpranke@chromium.org
The CQ bit was unchecked by dpranke@chromium.org
Description was changed from ========== Flip the last Mac GYP bots to GN (the ASAN bots): This flips the remaining Mac builders to GN. A number of browser_tests that use NaCl are failing under ASAN, so we disable NaCl for now. This affects: - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng TBR=rsesek@chromium.org BUG=618468, 630322, 632059 ========== to ========== Flip the last Mac GYP bots to GN (the ASAN bots): This flips the remaining Mac builders to GN. A number of browser_tests that use NaCl are failing under ASAN, so we disable NaCl for now. This affects: - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng TBR=rsesek@chromium.org BUG=618468, 630322, 632059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ==========
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM!! 🤘
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_asan_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_asan...)
Description was changed from ========== Flip the last Mac GYP bots to GN (the ASAN bots): This flips the remaining Mac builders to GN. A number of browser_tests that use NaCl are failing under ASAN, so we disable NaCl for now. This affects: - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng TBR=rsesek@chromium.org BUG=618468, 630322, 632059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ========== to ========== Flip the last Mac GYP bots to GN (the ASAN bots): This flips the remaining Mac builders to GN. A number of browser_tests that use NaCl are failing under ASAN, so we disable NaCl for now. This affects: - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng TBR=rsesek@chromium.org, brettw@chromium.org, jyasskin@chromium.org BUG=618468, 630322, 632059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ==========
dpranke@chromium.org changed reviewers: + brettw@chromium.org, jyasskin@chromium.org
TBR'ing brettw@ and jyasskin for the chrome_service_worker_browsertest.cc change, which is hopefully correct ...
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org Link to the patchset: https://codereview.chromium.org/2168713003/#ps60001 (title: "disable chrome_service_worker_browsertest.cc when nacl is disabled")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jyasskin@chromium.org changed reviewers: + kinuko@chromium.org
-> Kinuko to double-check the change in location of the service work test line.
Message was sent while issue was closed.
Description was changed from ========== Flip the last Mac GYP bots to GN (the ASAN bots): This flips the remaining Mac builders to GN. A number of browser_tests that use NaCl are failing under ASAN, so we disable NaCl for now. This affects: - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng TBR=rsesek@chromium.org, brettw@chromium.org, jyasskin@chromium.org BUG=618468, 630322, 632059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ========== to ========== Flip the last Mac GYP bots to GN (the ASAN bots): This flips the remaining Mac builders to GN. A number of browser_tests that use NaCl are failing under ASAN, so we disable NaCl for now. This affects: - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng TBR=rsesek@chromium.org, brettw@chromium.org, jyasskin@chromium.org BUG=618468, 630322, 632059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Flip the last Mac GYP bots to GN (the ASAN bots): This flips the remaining Mac builders to GN. A number of browser_tests that use NaCl are failing under ASAN, so we disable NaCl for now. This affects: - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng TBR=rsesek@chromium.org, brettw@chromium.org, jyasskin@chromium.org BUG=618468, 630322, 632059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng ========== to ========== Flip the last Mac GYP bots to GN (the ASAN bots): This flips the remaining Mac builders to GN. A number of browser_tests that use NaCl are failing under ASAN, so we disable NaCl for now. This affects: - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng TBR=rsesek@chromium.org, brettw@chromium.org, jyasskin@chromium.org BUG=618468, 630322, 632059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng Committed: https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5 Cr-Commit-Position: refs/heads/master@{#408345} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5 Cr-Commit-Position: refs/heads/master@{#408345}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2184363003/ by benwells@chromium.org. The reason for reverting is: The Mac ASAN bot is not compiling after this. Example stdio: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Build.... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
