Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2168713003: Flip the last Mac GYP bots to GN (the ASAN bots) (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_mac_perf
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip the last Mac GYP bots to GN (the ASAN bots): This flips the remaining Mac builders to GN. A number of browser_tests that use NaCl are failing under ASAN, so we disable NaCl for now. This affects: - chromium.fyi - ClangToTMacASan - chromium.lkgr - Mac ASAN Debug - Mac ASAN Release Media - Mac ASAN Release - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_asan_rel_ng TBR=rsesek@chromium.org, brettw@chromium.org, jyasskin@chromium.org BUG=618468, 630322, 632059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng Committed: https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5 Cr-Commit-Position: refs/heads/master@{#408345}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : disable nacl and try again #

Patch Set 4 : disable chrome_service_worker_browsertest.cc when nacl is disabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 3 8 chunks +30 lines, -19 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-21 01:12:54 UTC) #1
Robert Sesek
This won't work yet (https://bugs.chromium.org/p/chromium/issues/detail?id=630322).
4 years, 5 months ago (2016-07-21 16:37:59 UTC) #2
Dirk Pranke
On 2016/07/21 16:37:59, Robert Sesek wrote: > This won't work yet > (https://bugs.chromium.org/p/chromium/issues/detail?id=630322). Ack, will ...
4 years, 5 months ago (2016-07-21 17:07:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168713003/40001
4 years, 4 months ago (2016-07-27 23:12:26 UTC) #10
Robert Sesek
LGTM!! 🤘
4 years, 4 months ago (2016-07-28 00:44:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_asan_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_asan_rel_ng/builds/4182)
4 years, 4 months ago (2016-07-28 02:24:54 UTC) #13
Dirk Pranke
TBR'ing brettw@ and jyasskin for the chrome_service_worker_browsertest.cc change, which is hopefully correct ...
4 years, 4 months ago (2016-07-28 05:20:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168713003/60001
4 years, 4 months ago (2016-07-28 05:21:00 UTC) #19
Jeffrey Yasskin
-> Kinuko to double-check the change in location of the service work test line.
4 years, 4 months ago (2016-07-28 05:28:21 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-28 06:17:56 UTC) #23
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5 Cr-Commit-Position: refs/heads/master@{#408345}
4 years, 4 months ago (2016-07-28 06:20:04 UTC) #25
benwells
4 years, 4 months ago (2016-07-28 06:44:55 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2184363003/ by benwells@chromium.org.

The reason for reverting is: The Mac ASAN bot is not compiling after this.

Example stdio:
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Build....

Powered by Google App Engine
This is Rietveld 408576698