Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2168713002: Removed sync error menu item from the wrench menu (material design user menu only) (Closed)

Created:
4 years, 5 months ago by Jane
Modified:
4 years, 5 months ago
Reviewers:
*Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed sync error menu item from the wrench menu (material design user menu only) This is only for when #show-material-design-user-menu is enabled. For this case, sync error surfacing has been migrated to be in the user menu (https://codereview.chromium.org/2151513002/). Therefore, there shouldn't be a menu item in the wrench menu or any other surfacing UI for sync errors any more. See project design doc: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xrfx2rucezz BUG=615893 Committed: https://crrev.com/17508904c91aa277f580b613b36807097a67dea1 Cr-Commit-Position: refs/heads/master@{#406677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/sync/sync_global_error.cc View 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Jane
Hi Nicolas, PTAL, thanks! (I hope I'm doing this the right way!)
4 years, 5 months ago (2016-07-20 20:20:17 UTC) #3
Nicolas Zea
FYI, it's good to have your commit message be limited to 80 character lines as ...
4 years, 5 months ago (2016-07-20 20:38:49 UTC) #4
Jane
Thanks for the quick reply and the FYI - good to learn that!
4 years, 5 months ago (2016-07-20 20:44:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168713002/1
4 years, 5 months ago (2016-07-20 21:34:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 21:40:11 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 21:42:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17508904c91aa277f580b613b36807097a67dea1
Cr-Commit-Position: refs/heads/master@{#406677}

Powered by Google App Engine
This is Rietveld 408576698