Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2168703002: Provide a message to Google Update for the user when a system-level Chrome is already installed. (Closed)

Created:
4 years, 5 months ago by grt (UTC plus 2)
Modified:
4 years, 3 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide a message to Google Update for the user when a system-level Chrome is already installed. BUG=625322 Committed: https://crrev.com/70c65451381988189ef8d591f581ac62653f2829 Cr-Commit-Position: refs/heads/master@{#413812}

Patch Set 1 #

Patch Set 2 : that didn't work, use a message instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/app/chromium_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/installer/util/prebuild/create_string_rc.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
grt (UTC plus 2)
This resolves an oldie. Time for a review? Thanks.
4 years, 4 months ago (2016-08-19 12:07:21 UTC) #9
robertshield
LGTM Hopefully the omaha dialog isn't overlaid by the Chrome window that pops up.
4 years, 3 months ago (2016-08-23 17:13:05 UTC) #14
grt (UTC plus 2)
On 2016/08/23 17:13:05, robertshield wrote: > LGTM > > Hopefully the omaha dialog isn't overlaid ...
4 years, 3 months ago (2016-08-23 17:33:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168703002/20001
4 years, 3 months ago (2016-08-23 17:34:29 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-23 19:19:51 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-23 19:21:44 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70c65451381988189ef8d591f581ac62653f2829
Cr-Commit-Position: refs/heads/master@{#413812}

Powered by Google App Engine
This is Rietveld 408576698