Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2168663002: Bypass cached element rects in AXLayoutObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add link to bug Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
index 3cf57b9846c1fbab4ead98a655ade10a90b46edd..30a38fc1949f432f690f9bb5bc3b58e3fe43974f 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
@@ -201,21 +201,10 @@ LayoutRect AXLayoutObject::elementRect() const
{
if (!m_explicitElementRect.isEmpty())
return m_explicitElementRect;
- if (!m_layoutObject)
- return LayoutRect();
- if (!m_layoutObject->isBox())
- return computeElementRect();
-
- for (const AXObject* obj = this; obj; obj = obj->parentObject()) {
- if (obj->isAXLayoutObject())
- toAXLayoutObject(obj)->checkCachedElementRect();
- }
- for (const AXObject* obj = this; obj; obj = obj->parentObject()) {
- if (obj->isAXLayoutObject())
- toAXLayoutObject(obj)->updateCachedElementRect();
- }
- return m_cachedElementRect;
+ // FIXME(dmazzoni): use relative bounds instead since this is a bottleneck.
+ // http://crbug.com/618120
+ return computeElementRect();
}
SkMatrix44 AXLayoutObject::transformFromLocalParentFrame() const
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698