Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2168653005: Revert of Set proper result (purple/red) for "Uncaught Exception" and "Failure reason" steps (Closed)

Created:
4 years, 5 months ago by martiniss
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Set proper result (purple/red) for "Uncaught Exception" and "Failure reason" steps (patchset #1 id:1 of https://codereview.chromium.org/2142833002/ ) Reason for revert: Broke sheriff-o-matic (https://screenshot.googleplex.com/td2M1aXN8S4); it caused a bunch of duplicate alerts to show up. I believe we can cause the step to turn purple without having it show up as a failing step, which incorrectly triggers a lot of our sheriffing tools. Original issue's description: > Set proper result (purple/red) for "Uncaught Exception" and "Failure reason" steps > > BUG=none > > Committed: https://github.com/luci/recipes-py/commit/6bf9ca763de94c641328900358642ec44cf3932e TBR=estaab@chromium.org,iannucci@chromium.org,phajdan.jr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none Committed: https://github.com/luci/recipes-py/commit/4278a31afc8618c43ee029b85eba8f5aa3491dc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M recipes.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
martiniss
Created Revert of Set proper result (purple/red) for "Uncaught Exception" and "Failure reason" steps
4 years, 5 months ago (2016-07-20 22:46:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168653005/1
4 years, 5 months ago (2016-07-20 22:46:37 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 22:49:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/4278a31afc8618c43ee029b85eba8f5aa34...

Powered by Google App Engine
This is Rietveld 408576698