Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

Issue 2168653003: Pass through audio if HRTF database isn't loaded yet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp b/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
index 5f4d35fe4cae10eafbbf739aa36a2ca1ed32ad48..939c9a7d80dc99b002963efc786e10ff67cb9fbe 100644
--- a/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
@@ -134,8 +134,10 @@ void PannerHandler::process(size_t framesToProcess)
// HRTFDatabase should be loaded before proceeding when the panning model is HRTF.
if (m_panningModel == Panner::PanningModelHRTF && !listener()->isHRTFDatabaseLoaded()) {
if (context()->hasRealtimeConstraint()) {
- // Some BaseAudioContexts cannot block on the HRTFDatabase loader.
- destination->zero();
+ // Realtime AudioContext's cannot block on the HRTFDatabase
+ // loader. Instead, copy the input to the output so we can at
+ // least hear something until the database is ready.
+ destination->copyFrom(*source, m_channelInterpretation);
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698