Pass through audio if HRTF database isn't loaded yet.

Pass through audio if HRTF database isn't loaded yet.

If the HRTF panner isn't loaded yet, instead of zeroing the output,
copy the input to the output so that some audio is heard.  In either
case, there is a potential for a glitch, but it seems better to have
some audio output instead of silence.

The previous worst case was if loading the database is slow and the
sound is short, you won't hear anything.  Now you will.  If the sound
is long enough, you previously would hear silence and suddenly a
sound. Now you'll hear the sound which would suddenly change to due
spatialization.  We deem this to be less troublesome that not hearing the
initial sound at all.

BUG=629858
TEST=Run test from 602668 and audio from the first instance should be
heard

Committed: https://crrev.com/dec7ebfb35299bc15a0bc222dea7838b04d2c469
Cr-Commit-Position: refs/heads/master@{#406638}

[Raymond Toy, 2016-07-20 17:37:08]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 17:37:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-07-20 17:38:11]

Description was changed from

==========
Pass through audio if HRTF database isn't loaded yet.

If the HRTF panner isn't loaded yet, instead of zeroing the output,
copy the input to the output so that some audio is heard.  In either
case, there is a potential for a glitch, but it seems better to have
some audio output instead of silence.

The previous worst case was if loading the database is slow and the
sound is short, you won't hear anything.  Now you will.  If the sound
is long enough, you previously would hear silence and suddenly a
sound. Now you'll hear the sound which would suddenly change to due
spatialization.  We deem this to be less troublesome that no hearing a
sound at all.

BUG=629858
TEST=Run test from 602668 and audio from the first instance should be
heard
==========

to

==========
Pass through audio if HRTF database isn't loaded yet.

If the HRTF panner isn't loaded yet, instead of zeroing the output,
copy the input to the output so that some audio is heard.  In either
case, there is a potential for a glitch, but it seems better to have
some audio output instead of silence.

The previous worst case was if loading the database is slow and the
sound is short, you won't hear anything.  Now you will.  If the sound
is long enough, you previously would hear silence and suddenly a
sound. Now you'll hear the sound which would suddenly change to due
spatialization.  We deem this to be less troublesome that not hearing the
initial sound at all.

BUG=629858
TEST=Run test from 602668 and audio from the first instance should be
heard
==========

[Raymond Toy, 2016-07-20 17:38:58]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-07-20 17:38:59]

PTAL

[hongchan, 2016-07-20 17:43:12]

I also believe this is the right UX pattern. Having sound is better than
absolute silence. Either way we get the glitches anyway when you change the
panning model on the fly.

LGTM

[Raymond Toy, 2016-07-20 17:46:19]

The CQ bit was unchecked by rtoy@chromium.org

[Raymond Toy, 2016-07-20 17:46:57]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-07-20 17:47:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:29:19]

Description was changed from

==========
Pass through audio if HRTF database isn't loaded yet.

If the HRTF panner isn't loaded yet, instead of zeroing the output,
copy the input to the output so that some audio is heard.  In either
case, there is a potential for a glitch, but it seems better to have
some audio output instead of silence.

The previous worst case was if loading the database is slow and the
sound is short, you won't hear anything.  Now you will.  If the sound
is long enough, you previously would hear silence and suddenly a
sound. Now you'll hear the sound which would suddenly change to due
spatialization.  We deem this to be less troublesome that not hearing the
initial sound at all.

BUG=629858
TEST=Run test from 602668 and audio from the first instance should be
heard
==========

to

==========
Pass through audio if HRTF database isn't loaded yet.

If the HRTF panner isn't loaded yet, instead of zeroing the output,
copy the input to the output so that some audio is heard.  In either
case, there is a potential for a glitch, but it seems better to have
some audio output instead of silence.

The previous worst case was if loading the database is slow and the
sound is short, you won't hear anything.  Now you will.  If the sound
is long enough, you previously would hear silence and suddenly a
sound. Now you'll hear the sound which would suddenly change to due
spatialization.  We deem this to be less troublesome that not hearing the
initial sound at all.

BUG=629858
TEST=Run test from 602668 and audio from the first instance should be
heard
==========

[commit-bot: I haz the power, 2016-07-20 19:29:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-20 19:30:39]

Description was changed from

==========
Pass through audio if HRTF database isn't loaded yet.

If the HRTF panner isn't loaded yet, instead of zeroing the output,
copy the input to the output so that some audio is heard.  In either
case, there is a potential for a glitch, but it seems better to have
some audio output instead of silence.

The previous worst case was if loading the database is slow and the
sound is short, you won't hear anything.  Now you will.  If the sound
is long enough, you previously would hear silence and suddenly a
sound. Now you'll hear the sound which would suddenly change to due
spatialization.  We deem this to be less troublesome that not hearing the
initial sound at all.

BUG=629858
TEST=Run test from 602668 and audio from the first instance should be
heard
==========

to

==========
Pass through audio if HRTF database isn't loaded yet.

If the HRTF panner isn't loaded yet, instead of zeroing the output,
copy the input to the output so that some audio is heard.  In either
case, there is a potential for a glitch, but it seems better to have
some audio output instead of silence.

The previous worst case was if loading the database is slow and the
sound is short, you won't hear anything.  Now you will.  If the sound
is long enough, you previously would hear silence and suddenly a
sound. Now you'll hear the sound which would suddenly change to due
spatialization.  We deem this to be less troublesome that not hearing the
initial sound at all.

BUG=629858
TEST=Run test from 602668 and audio from the first instance should be
heard

Committed: https://crrev.com/dec7ebfb35299bc15a0bc222dea7838b04d2c469
Cr-Commit-Position: refs/heads/master@{#406638}
==========

[commit-bot: I haz the power, 2016-07-20 19:30:40]

Patchset 1 (id:??) landed as
https://crrev.com/dec7ebfb35299bc15a0bc222dea7838b04d2c469
Cr-Commit-Position: refs/heads/master@{#406638}