Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2168643003: Revert of have MakeFromImage fission the SkImage into a raster or a texture (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of have MakeFromImage fission the SkImage into a raster or a texture (patchset #1 id:1 of https://codereview.chromium.org/2167813002/ ) Reason for revert: broke ios build in chrome -- no_gpu? Original issue's description: > have MakeFromImage fission the SkImage into a raster or a texture > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167813002 > > Committed: https://skia.googlesource.com/skia/+/a61bfc6292edb990eae0b948648016550ef739a9 TBR=robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/3fb87201a104c9445fca341756a153f7b147c2a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -21 lines) Patch
M src/core/SkSpecialImage.cpp View 3 chunks +139 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
reed1
Created Revert of have MakeFromImage fission the SkImage into a raster or a texture
4 years, 5 months ago (2016-07-20 22:37:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168643003/1
4 years, 5 months ago (2016-07-20 22:38:11 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 22:38:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3fb87201a104c9445fca341756a153f7b147c2a5

Powered by Google App Engine
This is Rietveld 408576698