Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: test/cctest/test-cpu-profiler.cc

Issue 2168603003: Fixing test issue in test-cpu-profiler/TickLinesOptimized. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed duplicate disabling of the test in cctest.status Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc
index be2a8945d836ad1214c85030374a355a601e30ae..72e6c1a9b7e3e008c283c8d3037c186c8903a6fa 100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -1045,9 +1045,10 @@ static void TickLines(bool optimize) {
" n += m * m * m;\n"
" }\n"
"}\n"
+ "%s();"
"%s(%s);\n"
"%s();\n",
- func_name, opt_func, func_name, func_name);
+ func_name, func_name, opt_func, func_name, func_name);
CompileRun(script.start());
@@ -1055,6 +1056,8 @@ static void TickLines(bool optimize) {
v8::Utils::OpenHandle(*GetFunction(env.local(), func_name)));
CHECK(func->shared());
CHECK(func->shared()->abstract_code());
+ CHECK(!optimize || func->IsOptimized() ||
+ !CcTest::i_isolate()->use_crankshaft());
i::AbstractCode* code = func->abstract_code();
CHECK(code);
i::Address code_address = code->instruction_start();
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698