Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2168603002: Fallback to 300x150 instead of 0x0 size for SVG inside content() (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fallback to 300x150 instead of 0x0 size for SVG inside content() Prior to r379801, the fallback 300x150 in SVGImage::dataChanged() was used. Post r379801 we instead used the empty rect as fallback. Both are probably wrong but 300x150 matches what we did previously more closely and we are less likely to end up with an empty image. BUG=623528 Review-Url: https://codereview.chromium.org/2121973002 Cr-Commit-Position: refs/heads/master@{#404374} (cherry picked from commit da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae) Committed: https://chromium.googlesource.com/chromium/src/+/7815a45a74afc00768f304acc60272ca653bec86

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
fs
4 years, 5 months ago (2016-07-20 12:00:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7815a45a74afc00768f304acc60272ca653bec86 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698