Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2168583003: Remove leftover audioModem and copresensePrivate features. (Closed)

Created:
4 years, 5 months ago by rkc
Modified:
4 years, 5 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Charlie
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove leftover audioModem and copresensePrivate features. The removal of the API missed the removal of these features. Removing them now. R=rdevlin.cronin@chromium.org BUG=496900 Committed: https://crrev.com/0ed977747d42adb8dfe2caee57d9aa8ddb2cceb8 Cr-Commit-Position: refs/heads/master@{#406900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -40 lines) Patch
M chrome/common/extensions/api/_api_features.json View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
rkc
4 years, 5 months ago (2016-07-21 01:11:26 UTC) #1
Devlin
lgtm, thanks for the cleanup
4 years, 5 months ago (2016-07-21 15:27:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168583003/1
4 years, 5 months ago (2016-07-21 17:28:33 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 18:05:13 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:07:21 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ed977747d42adb8dfe2caee57d9aa8ddb2cceb8
Cr-Commit-Position: refs/heads/master@{#406900}

Powered by Google App Engine
This is Rietveld 408576698