Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2168573002: X87: Revert of [builtins] Introduce a builtin for Abort(). (patchset #5 id:80001 of https://coderev… (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Revert of [builtins] Introduce a builtin for Abort(). (patchset #5 id:80001 of https://codereview.chromium.org/2156923002/ ). port 3e8f49ab59206b587c6c44a58eda954a76355409 (r37883) original commit message: Reason for revert: Blocks roll: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/1622 Original issue's description: > [builtins] Introduce a builtin for Abort(). > > Calling Runtime::kAbort through a builtin instead of the c-entry stub > will allow to generate the call in a background thread, because a > builtin provides its own handle, whereas a code stub does not. > > @v8-mips-ports: Could you take a special look at the padding that is > done in MacroAssembler::Abort()? > > R=bmeurer@chromium.org, titzer@chromium.org, mstarzinger@chromium.org, v8-mips-ports@googlegroups.com, v8-arm-ports@googlegroups.com > > Committed: https://crrev.com/9be015a254cfff871c56cd129523a729637e9158 > Cr-Commit-Position: refs/heads/master@{#37854} BUG= Committed: https://crrev.com/870fac08c921d0f6bb42dd8b5344296a478073e8 Cr-Commit-Position: refs/heads/master@{#37888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M src/builtins/x87/builtins-x87.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-20 08:03:01 UTC) #2
Michael Hablich
On 2016/07/20 08:03:01, zhengxing.li wrote: > PTAL, thanks! lgtm
4 years, 5 months ago (2016-07-20 08:07:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168573002/1
4 years, 5 months ago (2016-07-20 08:08:10 UTC) #5
Weiliang
lgtm
4 years, 5 months ago (2016-07-20 08:08:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 08:32:17 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 08:32:19 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 08:34:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/870fac08c921d0f6bb42dd8b5344296a478073e8
Cr-Commit-Position: refs/heads/master@{#37888}

Powered by Google App Engine
This is Rietveld 408576698