Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2168563002: Implicitly pass 'scope()' as parent scope for function scopes (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implicitly pass 'scope()' as parent scope for function scopes This creates the guarantee that we can compute the parent scope later on. We'll do the same for other types of scopes as well (with perhaps a limited number of exceptions that will need to be eagerly allocated). BUG=v8:5209 Committed: https://crrev.com/90015a1fe0bed544bb78e7aab76f164246e15a0d Cr-Commit-Position: refs/heads/master@{#37898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M src/parsing/parser.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M src/parsing/parser-base.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/parsing/preparser.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 5 months ago (2016-07-20 07:46:18 UTC) #2
marja
lgtm
4 years, 5 months ago (2016-07-20 08:46:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168563002/1
4 years, 5 months ago (2016-07-20 09:05:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 09:35:39 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 09:39:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90015a1fe0bed544bb78e7aab76f164246e15a0d
Cr-Commit-Position: refs/heads/master@{#37898}

Powered by Google App Engine
This is Rietveld 408576698