Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2168533002: Remove window_manager.mojom. (Closed)

Created:
4 years, 5 months ago by hidehiko
Modified:
4 years, 5 months ago
Reviewers:
oshima, dcheng
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, oshima+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, davemoore+watch_chromium.org, qsr+mojo_chromium.org, Luis Héctor Chávez, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove window_manager.mojom. Now the feature is moved to wayland, we can remove it. BUG=b/29728385 TEST=Build and run ARC, with client side WindowManagerInstance removal. Committed: https://crrev.com/3211e12bab0c97ca8b24b320bb3fde4d5e55ae76 Cr-Commit-Position: refs/heads/master@{#407070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -69 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M components/arc.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M components/arc/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/arc/arc_bridge_service.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/arc/arc_bridge_service_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/arc/arc_bridge_service_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M components/arc/arc_service_manager.h View 2 chunks +0 lines, -7 lines 0 comments Download
M components/arc/arc_service_manager.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M components/arc/common/arc_bridge.mojom View 2 chunks +1 line, -5 lines 0 comments Download
D components/arc/common/window_manager.mojom View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
hidehiko
PTAL: oshima@. FYI: lhchavez@, reveman@. I'll land this after client side change is landed and ...
4 years, 5 months ago (2016-07-20 13:34:40 UTC) #6
oshima
lgtm
4 years, 5 months ago (2016-07-21 22:03:51 UTC) #7
hidehiko
Thank you for review. Now client side change was rolled. dcheng@, PTAL as an OWNER ...
4 years, 5 months ago (2016-07-22 03:32:12 UTC) #9
dcheng
rs lgtm for mojom
4 years, 5 months ago (2016-07-22 03:33:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168533002/1
4 years, 5 months ago (2016-07-22 04:06:06 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 05:17:38 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 05:20:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3211e12bab0c97ca8b24b320bb3fde4d5e55ae76
Cr-Commit-Position: refs/heads/master@{#407070}

Powered by Google App Engine
This is Rietveld 408576698