Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2168513005: Reland PaintChunk::id (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
chrishtr, pdr.
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland PaintChunk::id The id will be used in rasterization paint invalidation to match old and new paint chunks. It can be also used in incremental layerization. Original review url: https://codereview.chromium.org/2116693002 BUG=510908, 629946 Review-Url: https://codereview.chromium.org/2116693002 Committed: https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da Cr-Original-Commit-Position: refs/heads/master@{#406461} Cr-Commit-Position: refs/heads/master@{#406793}

Patch Set 1 #

Patch Set 2 : Disable PaintChunker tests on Windows debug #

Patch Set 3 : git cl try -b win_blink_dbg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -131 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h View 3 chunks +16 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunk.h View 5 chunks +36 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp View 1 chunk +86 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunker.h View 3 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunker.cpp View 4 chunks +28 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp View 1 2 5 chunks +173 lines, -78 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 6 chunks +7 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScopedPaintChunkProperties.h View 2 chunks +16 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/FakeDisplayItemClient.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/PaintPrinters.cpp View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 26 (17 generated)
Xianzhu
The only change compared to the original CL is to disable the tests mysteriously failed ...
4 years, 5 months ago (2016-07-20 20:52:43 UTC) #5
pdr.
On 2016/07/20 at 20:52:43, wangxianzhu wrote: > The only change compared to the original CL ...
4 years, 5 months ago (2016-07-20 21:00:40 UTC) #6
pdr.
On 2016/07/20 at 21:00:40, pdr. wrote: > On 2016/07/20 at 20:52:43, wangxianzhu wrote: > > ...
4 years, 5 months ago (2016-07-20 21:01:34 UTC) #9
chrishtr
Let me try to repro this on a Windows machine I have here first.
4 years, 5 months ago (2016-07-20 22:10:21 UTC) #10
Xianzhu
On 2016/07/20 22:10:21, chrishtr wrote: > Let me try to repro this on a Windows ...
4 years, 5 months ago (2016-07-20 22:14:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168513005/20001
4 years, 5 months ago (2016-07-21 00:54:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168513005/40001
4 years, 5 months ago (2016-07-21 05:46:02 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 07:08:57 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 07:13:01 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a1101d498d5054ecda5c4f6481b4738d7873b4da
Cr-Commit-Position: refs/heads/master@{#406793}

Powered by Google App Engine
This is Rietveld 408576698