Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2168493002: Regression tests for 25658 and 24817. (Closed)

Created:
4 years, 5 months ago by Jacob
Modified:
4 years, 5 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Regression tests for 25658 and 24817. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M tests/html/html.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
A tests/html/js_typed_interop_bind_this_test.dart View 1 chunk +53 lines, -0 lines 0 comments Download
A tests/html/js_typed_interop_window_property_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
Tests that verify that issues 25658 and 24817 have been fixed and that we'd just ...
4 years, 5 months ago (2016-07-20 00:01:32 UTC) #2
Alan Knight
lgtm
4 years, 5 months ago (2016-07-20 00:05:13 UTC) #3
Jacob
4 years, 5 months ago (2016-07-20 00:09:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bcf224b3e68924a1d5a76659063256cb8e6f32d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698