Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2168483006: Converts exit_warning_handler to use ash common types (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts exit_warning_handler to use ash common types BUG=626869 TEST=none R=msw@chromium.org Committed: https://crrev.com/d02e723a6b13338355523ca3ea45e6b807dc17c4 Cr-Commit-Position: refs/heads/master@{#406723}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M ash/accelerators/exit_warning_handler.cc View 4 chunks +7 lines, -10 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
sky
4 years, 5 months ago (2016-07-20 23:31:50 UTC) #1
msw
lgtm with an optional nit https://codereview.chromium.org/2168483006/diff/1/ash/accelerators/exit_warning_handler.cc File ash/accelerators/exit_warning_handler.cc (right): https://codereview.chromium.org/2168483006/diff/1/ash/accelerators/exit_warning_handler.cc#newcode5 ash/accelerators/exit_warning_handler.cc:5: #include "ash/accelerators/exit_warning_handler.h" optional nit: ...
4 years, 5 months ago (2016-07-20 23:35:25 UTC) #4
sky
I'm going to do the move separately.
4 years, 5 months ago (2016-07-20 23:37:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168483006/1
4 years, 5 months ago (2016-07-20 23:38:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 00:19:22 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 00:22:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d02e723a6b13338355523ca3ea45e6b807dc17c4
Cr-Commit-Position: refs/heads/master@{#406723}

Powered by Google App Engine
This is Rietveld 408576698