Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2168473002: Record that MediaStream creates MediaStreamTracks (Closed)

Created:
4 years, 5 months ago by Harry Terkelsen
Modified:
4 years, 5 months ago
Reviewers:
Alan Knight, sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : generate the files #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Harry Terkelsen
4 years, 5 months ago (2016-07-19 23:32:07 UTC) #2
Alan Knight
https://codereview.chromium.org/2168473002/diff/20001/tools/dom/scripts/dartmetadata.py File tools/dom/scripts/dartmetadata.py (right): https://codereview.chromium.org/2168473002/diff/20001/tools/dom/scripts/dartmetadata.py#newcode263 tools/dom/scripts/dartmetadata.py:263: "@Creates('JSExtendableArray|MediaStreamTrack')", The IDL says this returns sequence<MediaStreamTrack>. Is it ...
4 years, 5 months ago (2016-07-19 23:42:21 UTC) #3
sra1
On 2016/07/19 23:42:21, Alan Knight wrote: > https://codereview.chromium.org/2168473002/diff/20001/tools/dom/scripts/dartmetadata.py > File tools/dom/scripts/dartmetadata.py (right): > > https://codereview.chromium.org/2168473002/diff/20001/tools/dom/scripts/dartmetadata.py#newcode263 ...
4 years, 5 months ago (2016-07-19 23:44:23 UTC) #4
Alan Knight
lgtm Ah, right. @Creates, not @Returns. And I tried it and the metadata doesn't work. ...
4 years, 5 months ago (2016-07-19 23:53:14 UTC) #5
Harry Terkelsen
4 years, 5 months ago (2016-07-20 00:00:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
faaff39aa9efea958f56e29ba6c9cecfb84d4668 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698