Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2168463005: Add EMEA-based reviewers for UseCounter histogram changes. (Closed)

Created:
4 years, 5 months ago by Mike West
Modified:
4 years, 5 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add EMEA-based reviewers for UseCounter histogram changes. We're TBRing UseCounter changes to Ilya, et al. more often than I'd like. This patch adds Jochen and I as EMEA-based reviewers for these mechanical changes until such time as the mechanically-generated UseCounter data is split out into a file with broader ownership. R=jochen@chromium.org,isherman@chromium.org,asvitkine@chromium.org Committed: https://crrev.com/63f867c5a2a970ef584719d17e4ecf8f1dbc436d Cr-Commit-Position: refs/heads/master@{#406670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/metrics/histograms/OWNERS View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Ilya Sherman
LGTM -- thanks for thinking about this and volunteering to fill in! Please wait for ...
4 years, 5 months ago (2016-07-20 19:33:04 UTC) #1
Alexei Svitkine (slow)
lgtm
4 years, 5 months ago (2016-07-20 19:42:27 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-20 19:57:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168463005/1
4 years, 5 months ago (2016-07-20 20:15:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 21:15:29 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 21:17:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63f867c5a2a970ef584719d17e4ecf8f1dbc436d
Cr-Commit-Position: refs/heads/master@{#406670}

Powered by Google App Engine
This is Rietveld 408576698