Converted Observatory isolate-nav-menu element

runtime/observatory/lib/src/elements/nav/isolate_menu.dart

Index: runtime/observatory/lib/src/elements/nav/isolate_menu.dart
diff --git a/runtime/observatory/lib/src/elements/nav/isolate_menu.dart b/runtime/observatory/lib/src/elements/nav/isolate_menu.dart
new file mode 100644
index 0000000000000000000000000000000000000000..09928115d586ee66f89cba07b258e98d8d6e58e9
--- /dev/null
+++ b/runtime/observatory/lib/src/elements/nav/isolate_menu.dart
@@ -0,0 +1,110 @@
+// Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:html';
+import 'dart:async';
+import 'package:observatory/models.dart' as M
+  show IsolateRef, IsolateUpdateEvent;
+import 'package:observatory/src/elements/helpers/tag.dart';
+import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
+import 'package:observatory/src/elements/nav/menu.dart';
+import 'package:observatory/src/elements/nav/menu_item.dart';
+
+class NavIsolateMenuElement extends HtmlElement implements Renderable {
+  static const tag = const Tag<NavIsolateMenuElement>('nav-isolate-menu',
+                     dependencies: const [NavMenuElement.tag,
+                                          NavMenuItemElement.tag]);
+
+  RenderingScheduler _r;
+
+  Stream<RenderedEvent<NavIsolateMenuElement>> get onRendered => _r.onRendered;
+
+  Stream<M.IsolateUpdateEvent> _updates;
+  StreamSubscription _updatesSubscription;
+
+  bool _last;
+  M.IsolateRef _isolate;
+  bool get last => _last;
+  M.IsolateRef get isolate => _isolate;
+  set last(bool value) {
+    if (_last != value) {
+      _last = value;

[Cutch, 2016/07/20 13:55:25]

this block of code for setting a bool (and marking as dirty / schedule
notification) is repeated a lot. Perhaps make a helper routine.

[cbernaschina, 2016/07/20 20:01:42]

Done.

+      _r.dirty();
+    } else {
+      _r.scheduleNotification();
+    }
+  }
+
+  factory NavIsolateMenuElement(M.IsolateRef isolate,
+                      Stream<M.IsolateUpdateEvent> updates, {bool last: false,

[Cutch, 2016/07/20 13:55:25]

indentation is wrong here

[cbernaschina, 2016/07/20 20:01:42]

Done.

+                      RenderingQueue queue}) {
+    assert(isolate != null);
+    assert(last != null);
+    NavIsolateMenuElement e = document.createElement(tag.name);
+    e._r = new RenderingScheduler(e, queue: queue);
+    e._isolate = isolate;
+    e._last = last;
+    e._updates = updates;
+    return e;
+  }
+
+  NavIsolateMenuElement.created() : super.created() {
+    _r = new RenderingScheduler(this);
+    createShadowRoot();
+  }
+
+  @override
+  void attached() {
+    super.attached();
+    assert(_isolate != null);
+    assert(_updates != null);
+    _r.enable();
+    _updatesSubscription = _updates
+      .where((M.IsolateUpdateEvent e) => e.isolate.id == isolate.id)
+      .listen((M.IsolateUpdateEvent e) { _isolate = e.isolate; _r.dirty(); });
+  }
+
+  @override
+  void detached() {
+    super.detached();
+    _r.disable(notify: true);
+    shadowRoot.children = [];
+    assert(_updatesSubscription != null);
+    _updatesSubscription.cancel();
+    _updatesSubscription = null;
+  }
+
+  void render() {
+    var url_tail = '?isolateId=${Uri.encodeComponent(isolate.id)}';

[Cutch, 2016/07/20 13:55:25]

Consider using the Uri class to build your uris.

[cbernaschina, 2016/07/20 20:01:42]

Done.

+    shadowRoot.children = [
+      new NavMenuElement(isolate.name, last: last, queue: _r.queue,
+                link: '/inspect$url_tail')
+        ..children = [
+          new NavMenuItemElement('debugger', queue: _r.queue,
+                link: '/debugger$url_tail'),

[Cutch, 2016/07/20 13:55:25]

Use the Uri class instead of hand written concatenation. 

[cbernaschina, 2016/07/20 20:01:42]

Done.

+          new NavMenuItemElement('class hierarchy', queue: _r.queue,
+                link: '/class-tree$url_tail'),
+          new NavMenuItemElement('cpu profile', queue: _r.queue,
+                link: '/profiler$url_tail'),
+          new NavMenuItemElement('cpu profile (table)', queue: _r.queue,
+                link: '/profiler-table$url_tail'),
+          new NavMenuItemElement('allocation profile', queue: _r.queue,
+                link: '/allocation-profiler$url_tail'),
+          new NavMenuItemElement('heap map', queue: _r.queue,
+                link: '/heap-map$url_tail'),
+          new NavMenuItemElement('metrics', queue: _r.queue,
+                link: '/metrics$url_tail'),
+          new NavMenuItemElement('heap snapshot', queue: _r.queue,
+                link: '/heap-snapshot$url_tail'),
+          new NavMenuItemElement('persistent handles', queue: _r.queue,
+                link: '/persistent-handles$url_tail'),
+          new NavMenuItemElement('ports', queue: _r.queue,
+                link: '/ports$url_tail'),
+          new NavMenuItemElement('logging', queue: _r.queue,
+                link: '/logging$url_tail'),
+          new ContentElement()
+        ]
+    ];
+  }
+}