Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: runtime/observatory/lib/src/elements/nav/menu_item_wrapper.dart

Issue 2168463004: Converted Observatory isolate-nav-menu element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merged with master Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/nav/menu_item_wrapper.dart
diff --git a/runtime/observatory/lib/src/elements/nav/menu_item_wrapper.dart b/runtime/observatory/lib/src/elements/nav/menu_item_wrapper.dart
index ff216fdffa9ec97e0a753b78f6ec60f21b194060..045d67a90fe1809ae2738ff4e380b577e874459b 100644
--- a/runtime/observatory/lib/src/elements/nav/menu_item_wrapper.dart
+++ b/runtime/observatory/lib/src/elements/nav/menu_item_wrapper.dart
@@ -46,7 +46,7 @@ class NavMenuItemElementWrapper extends HtmlElement {
if (_anchor == null) return;
shadowRoot.children = [
- new NavMenuItemElement(_anchor, link: _link,
+ new NavMenuItemElement(_anchor, link: '#$link',
Cutch 2016/07/22 13:38:17 why is the # character hard coded here?
cbernaschina 2016/07/22 17:26:42 After the introduction of the Uris helper we have
queue: ObservatoryApplication.app.queue)
..children = [new ContentElement()]
];

Powered by Google App Engine
This is Rietveld 408576698