Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: content/browser/download/save_package_unittest.cc

Issue 2168403003: Avoid file IO on UI thread by moving more save-page-as stuff to the FILE thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment tweaks for base::nix::GetFileMimeType + two extra DCHECK_CURRENTLY_ON asserts in SavePackag… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/save_package.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/save_package_unittest.cc
diff --git a/content/browser/download/save_package_unittest.cc b/content/browser/download/save_package_unittest.cc
index c75a28bf6c75c58962104ac0012876a80cb3cd94..f2999fcbaae4b7572a9a938974f4f37a239bda23 100644
--- a/content/browser/download/save_package_unittest.cc
+++ b/content/browser/download/save_package_unittest.cc
@@ -419,11 +419,9 @@ TEST_F(SavePackageTest, MAYBE_TestSuggestedSaveNames) {
GURL url = net::URLRequestMockHTTPJob::GetMockUrl("save_page/a.htm");
NavigateAndCommit(url);
for (size_t i = 0; i < arraysize(kSuggestedSaveNames); ++i) {
- scoped_refptr<SavePackage> save_package(new SavePackage(contents()));
- save_package->page_url_ = GURL(kSuggestedSaveNames[i].page_url);
- save_package->title_ = kSuggestedSaveNames[i].page_title;
-
- base::FilePath save_name = save_package->GetSuggestedNameForSaveAs(
+ base::FilePath save_name = SavePackage::GetSuggestedNameForSaveAs(
+ kSuggestedSaveNames[i].page_title,
+ GURL(kSuggestedSaveNames[i].page_url),
kSuggestedSaveNames[i].ensure_html_extension, std::string());
EXPECT_EQ(kSuggestedSaveNames[i].expected_name, save_name.value()) <<
"Test case " << i;
« no previous file with comments | « content/browser/download/save_package.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698