Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: content/browser/download/save_package.h

Issue 2168403003: Avoid file IO on UI thread by moving more save-page-as stuff to the FILE thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment tweaks for base::nix::GetFileMimeType + two extra DCHECK_CURRENTLY_ON asserts in SavePackag… Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/nix/mime_util_xdg.h ('k') | content/browser/download/save_package.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/save_package.h
diff --git a/content/browser/download/save_package.h b/content/browser/download/save_package.h
index edc54841c8ef1c7017d7a0806c525d0b315c2e94..5cafea5461f9b093d7a41b9c99a0aca7aa06a1c1 100644
--- a/content/browser/download/save_package.h
+++ b/content/browser/download/save_package.h
@@ -303,9 +303,12 @@ class CONTENT_EXPORT SavePackage
static GURL GetUrlToBeSaved(WebContents* web_contents);
static base::FilePath CreateDirectoryOnFileThread(
+ const base::string16& title,
+ const GURL& page_url,
+ bool can_save_as_complete,
+ const std::string& mime_type,
const base::FilePath& website_save_dir,
const base::FilePath& download_save_dir,
- const base::FilePath& suggested_filename,
bool skip_dir_check);
void ContinueGetSaveInfo(bool can_save_as_complete,
const base::FilePath& suggested_path);
@@ -335,7 +338,9 @@ class CONTENT_EXPORT SavePackage
// Helper function for preparing suggested name for the SaveAs Dialog. The
// suggested name is determined by the web document's title.
- base::FilePath GetSuggestedNameForSaveAs(
+ static base::FilePath GetSuggestedNameForSaveAs(
+ const base::string16& title,
+ const GURL& page_url,
bool can_save_as_complete,
const std::string& contents_mime_type);
« no previous file with comments | « base/nix/mime_util_xdg.h ('k') | content/browser/download/save_package.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698