Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 21684002: [telemetry] Automatic hash file creation and upload to Cloud Storage. (Closed)

Created:
7 years, 4 months ago by dtu
Modified:
7 years, 4 months ago
Reviewers:
tonyg, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Automatic hash file creation and upload to Cloud Storage. BUG=223667 TEST=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215445

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Add to unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -18 lines) Patch
M tools/perf/PRESUBMIT.py View 2 chunks +5 lines, -1 line 0 comments Download
A tools/perf/page_sets/.gitignore View 1 1 chunk +12 lines, -0 lines 0 comments Download
A tools/perf/page_sets/PRESUBMIT.py View 1 chunk +66 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/cloud_storage.py View 4 chunks +18 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info.py View 4 chunks +12 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info_unittest.py View 1 7 chunks +28 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dtu
7 years, 4 months ago (2013-08-02 01:00:02 UTC) #1
tonyg
lgtm https://chromiumcodereview.appspot.com/21684002/diff/3001/tools/perf/page_sets/.gitignore File tools/perf/page_sets/.gitignore (right): https://chromiumcodereview.appspot.com/21684002/diff/3001/tools/perf/page_sets/.gitignore#newcode6 tools/perf/page_sets/.gitignore:6: *.png Maybe a good idea to add .gif ...
7 years, 4 months ago (2013-08-02 02:21:52 UTC) #2
dtu
https://codereview.chromium.org/21684002/diff/3001/tools/perf/page_sets/.gitignore File tools/perf/page_sets/.gitignore (right): https://codereview.chromium.org/21684002/diff/3001/tools/perf/page_sets/.gitignore#newcode6 tools/perf/page_sets/.gitignore:6: *.png On 2013/08/02 02:21:52, tonyg wrote: > Maybe a ...
7 years, 4 months ago (2013-08-02 23:19:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/21684002/9001
7 years, 4 months ago (2013-08-02 23:21:11 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-03 01:39:41 UTC) #5
Message was sent while issue was closed.
Change committed as 215445

Powered by Google App Engine
This is Rietveld 408576698