Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: chrome/browser/resources/settings/controls/settings_checkbox.html

Issue 2168383003: Hack to fix settings-checkbox mixin for 1.6.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Polymer160
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/settings_checkbox.html
diff --git a/chrome/browser/resources/settings/controls/settings_checkbox.html b/chrome/browser/resources/settings/controls/settings_checkbox.html
index fb3378372b15b3a3035818b292a2f50e1cc9976a..0acdf3da05e314fd7641dcb6186b9aac83099f6c 100644
--- a/chrome/browser/resources/settings/controls/settings_checkbox.html
+++ b/chrome/browser/resources/settings/controls/settings_checkbox.html
@@ -20,6 +20,13 @@
@apply(--settings-secondary);
}
+ #nonexistent {
+ /* HACK(michaelpg): Inform Polymer that this mixin can set "display". */
Dan Beam 2016/07/23 00:12:29 why does this need a #nonexistent, and not just be
Dan Beam 2016/07/23 00:14:15 or even better, display: initial; [1] https://dev
michaelpg 2016/07/23 00:15:23 That would override the mixin, and the checkbox wo
+ --settings-secondary-unchecked: {
+ display: block;
+ };
+ }
+
paper-checkbox:not([checked]) .secondary {
@apply(--settings-secondary-unchecked);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698