Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 2168343002: Revert "[wasm] Adding a convolution matrix filter test to highlight the performance advantages of J… (Closed)

Created:
4 years, 5 months ago by ritesht
Modified:
4 years, 5 months ago
Reviewers:
bradnelson, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[wasm] Adding a convolution matrix filter test to highlight the performance advantages of JITing" GC-Stress asserts in filter-jit. This reverts commit ccfd224ec3d1d9fd3b7e577f1db91bdf1e30d1f0. BUG=v8:5044 R=bradnelson@chromium.org Committed: https://crrev.com/b88701371218f512b33e862406e6b31ab82a6a01 Cr-Commit-Position: refs/heads/master@{#37961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1010 lines) Patch
M src/runtime/runtime-wasm.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M src/wasm/ast-decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D test/mjsunit/wasm/filter-jit.js View 1 chunk +0 lines, -998 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
ritesht
4 years, 5 months ago (2016-07-22 01:30:17 UTC) #1
bradn
lgtm
4 years, 5 months ago (2016-07-22 01:30:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168343002/1
4 years, 5 months ago (2016-07-22 01:30:57 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-22 01:30:58 UTC) #7
bradnelson
lgtm
4 years, 5 months ago (2016-07-22 01:43:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168343002/1
4 years, 5 months ago (2016-07-22 01:43:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 02:09:38 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 02:10:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b88701371218f512b33e862406e6b31ab82a6a01
Cr-Commit-Position: refs/heads/master@{#37961}

Powered by Google App Engine
This is Rietveld 408576698