Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216833005: Wire glDiscardFramebuffer up to Skia. (Closed)

Created:
6 years, 8 months ago by bsalomon
Modified:
6 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Wire glDiscardFramebuffer up to Skia. BUG=skia:2349 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_bindings_skia_in_process.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
bsalomon
6 years, 8 months ago (2014-03-28 17:34:15 UTC) #1
piman
lgtm
6 years, 8 months ago (2014-03-28 20:09:35 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-03-28 20:21:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bsalomon@google.com/216833005/1
6 years, 8 months ago (2014-03-28 20:22:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 01:32:24 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-29 01:32:24 UTC) #6
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-03-31 13:15:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bsalomon@google.com/216833005/1
6 years, 8 months ago (2014-03-31 13:16:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 14:50:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-31 14:50:32 UTC) #10
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-03-31 15:02:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bsalomon@google.com/216833005/1
6 years, 8 months ago (2014-03-31 15:03:00 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 16:35:57 UTC) #13
Message was sent while issue was closed. 
Change committed as 260562

Powered by Google App Engine
This is Rietveld 408576698