DevTools: only notify enabled presentation modes upon timeline start/end.

Source/devtools/front_end/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 61 matching lines @@
 
     this._categoryFilter = new WebInspector.TimelineCategoryFilter();
     this._durationFilter = new WebInspector.TimelineIsLongFilter();
     this._textFilter = new WebInspector.TimelineTextFilter();
 
     this._model.addFilter(new WebInspector.TimelineHiddenFilter());
     this._model.addFilter(this._categoryFilter);
     this._model.addFilter(this._durationFilter);
     this._model.addFilter(this._textFilter);
 
+    this._presentationModes = [
+        WebInspector.TimelinePanel.Mode.Events,
+        WebInspector.TimelinePanel.Mode.Frames,
+        WebInspector.TimelinePanel.Mode.Memory
+    ];
+    if (WebInspector.experimentsSettings.timelineFlameChart.isEnabled())
+        this._presentationModes.push(WebInspector.TimelinePanel.Mode.FlameChart);
+    if (Capabilities.canProfilePower)
+        this._presentationModes.push(WebInspector.TimelinePanel.Mode.Power);
+
     this._presentationModeSetting = WebInspector.settings.createSetting("timelineOverviewMode", WebInspector.TimelinePanel.Mode.Events);
 
     this._createStatusBarItems();
 
     this._topPane = new WebInspector.SplitView(true, false);
     this._topPane.element.id = "timeline-overview-panel";
     this._topPane.show(this.element);
     this._topPane.addEventListener(WebInspector.SplitView.Events.SidebarSizeChanged, this._sidebarResized, this);
     this._topPane.setResizable(false);
     this._createPresentationSelector();
@@ skipping 195 matching lines @@
     {
         this._viewsMap = {};
 
         var topPaneSidebarElement = this._topPane.sidebarElement();
         topPaneSidebarElement.id = "timeline-overview-sidebar";
 
         var overviewTreeElement = topPaneSidebarElement.createChild("ol", "sidebar-tree vbox");
         var topPaneSidebarTree = new TreeOutline(overviewTreeElement);
 
         this._overviewItems = {};
-        for (var mode in WebInspector.TimelinePanel.Mode) {
-            if (mode === WebInspector.TimelinePanel.Mode.FlameChart && !WebInspector.experimentsSettings.timelineFlameChart.isEnabled() ||
-                mode === WebInspector.TimelinePanel.Mode.Power && !Capabilities.canProfilePower)
-                continue;
+        for (var i = 0; i < this._presentationModes.length; ++i) {
+            var mode = this._presentationModes[i];
             this._overviewItems[mode] = new WebInspector.SidebarTreeElement("timeline-overview-sidebar-" + mode.toLowerCase(), WebInspector.UIString(mode));
             var item = this._overviewItems[mode];
             item.onselect = this._onModeChanged.bind(this, mode);
             topPaneSidebarTree.appendChild(item);
         }
     },
 
     _createStatusBarItems: function()
     {
         var panelStatusBarElement = this.element.createChild("div", "panel-status-bar");
@@ skipping 240 matching lines @@
         this._updateSelectionDetails();
     },
 
     /**
      * @param {boolean} userInitiated
      */
     _startRecording: function(userInitiated)
     {
         this._userInitiatedRecording = userInitiated;
         this._model.startRecording();
-        for (var mode in WebInspector.TimelinePanel.Mode)
-            this._viewsForMode(mode).overviewView.timelineStarted();
+        for (var i = 0; i < this._presentationModes.length; ++i)
+            this._viewsForMode(this._presentationModes[i]).overviewView.timelineStarted();
 
         if (userInitiated)
             WebInspector.userMetrics.TimelineStarted.record();
     },
 
     _stopRecording: function()
     {
         this._userInitiatedRecording = false;
         this._model.stopRecording();
-        for (var mode in WebInspector.TimelinePanel.Mode)
-            this._viewsForMode(mode).overviewView.timelineStopped();
+        for (var i = 0; i < this._presentationModes.length; ++i)
+            this._viewsForMode(this._presentationModes[i]).overviewView.timelineStopped();
     },
 
     /**
      * @return {boolean}
      */
     _toggleTimelineButtonClicked: function()
     {
         if (this._operationInProgress)
             return true;
         if (this._recordingInProgress())
@@ skipping 563 matching lines @@
      * @param {!WebInspector.TimelineModel.Record} record
      * @return {boolean}
      */
     accept: function(record)
     {
         return !this._hiddenRecords[record.type];
     },
 
     __proto__: WebInspector.TimelineModel.Filter.prototype
 }