third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js - Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js

Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js b/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js

index f1856ddc0e6a2632122723520c095673978dc496..9f708ecb2d675b1dd144132ec49f73a0418459e8 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js

@@ -77,9 +77,10 @@ WebInspector.CSSStyleSheetHeader.prototype = {

_viaInspectorResourceURL: function()

{

- var frame = this._cssModel.target().resourceTreeModel.frameForId(this.frameId);

- console.assert(frame);

- var parsedURL = new WebInspector.ParsedURL(frame.url);

+ var doc = this._cssModel.domModel().existingDocument();

pfeldman 2016/08/11 00:34:17 Depending on the iframe, these will be different d

eostroukhov-old 2016/08/17 01:09:02 Rewrote, assuming RTModel is always there.

+ if (!doc)

+ return "";

+ var parsedURL = new WebInspector.ParsedURL(doc.documentURL);

var fakeURL = "inspector://" + parsedURL.host + parsedURL.folderPathComponents;

if (!fakeURL.endsWith("/"))

fakeURL += "/";