third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: URL management was split into a separate CL Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js ('K') | « third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

index 28eedc23f4786d47ea05dc1201af0abca79f5e24..2cd97586c57b4419c38a01755b6b232691f9dc83 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -382,7 +382,8 @@ WebInspector.StylesSidebarPane.prototype = {

if (!cssModel || !node)

return;

this._userOperation = true;

- cssModel.requestViaInspectorStylesheet(node, onViaInspectorStyleSheet.bind(this));

+ var frameId = node.frameId() || this.resourceTreeModel().mainFrame.id;

pfeldman 2016/07/27 17:54:35 We should be able to operate nodes only here.

eostroukhov-old 2016/08/05 18:32:03 Reverted the change.

+ cssModel.requestViaInspectorStylesheet(node, frameId, onViaInspectorStyleSheet.bind(this));

/**

* @param {?WebInspector.CSSStyleSheetHeader} styleSheetHeader