third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js - Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

index 35c086065c3696fc23a4abba0ea5c094af330a65..d30faf06fbe11995c5fd2943afe2598b4c03f35f 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

@@ -32,18 +32,19 @@

* @constructor

* @extends {WebInspector.SDKModel}

* @param {!WebInspector.Target} target

+ * @param {!WebInspector.ResourceTreeModel} resourceTreeModel

* @param {!WebInspector.NetworkManager} networkManager

-WebInspector.NetworkLog = function(target, networkManager)

+WebInspector.NetworkLog = function(target, resourceTreeModel, networkManager)

dgozman 2016/07/22 17:19:43 Let's try to remove NetworkLog entirely. Or move i

eostroukhov-old 2016/07/25 19:36:11 I would like not to do this in this CL - it is alr

{

WebInspector.SDKModel.call(this, WebInspector.NetworkLog, target);

this._requests = [];

this._requestForId = {};

networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestStarted, this._onRequestStarted, this);

- target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this);

- target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._onLoad, this);

- target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.DOMContentLoaded, this._onDOMContentLoaded, this);

+ resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this);

+ resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._onLoad, this);

+ resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.DOMContentLoaded, this._onDOMContentLoaded, this);

}

/**