[DevTools] Explicitly require ResourceTreeModel

third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.SDKModel}
  * @param {!WebInspector.Target} target
+ * @param {!WebInspector.DOMModel} domModel
+ * @param {!WebInspector.ResourceTreeModel} resourceTreeModel
  */
-WebInspector.CSSModel = function(target)
+WebInspector.CSSModel = function(target, domModel, resourceTreeModel)
 {
     WebInspector.SDKModel.call(this, WebInspector.CSSModel, target);
-    this._domModel = WebInspector.DOMModel.fromTarget(target);
+    this._domModel = domModel;
+    this._resourceTreeModel = resourceTreeModel;

[dgozman, 2016/07/22 17:19:43]

TODO(lushnikov): CSSModel should not depend on frames and ResourceTreeModel.

[eostroukhov-old, 2016/07/25 19:36:11]

Done.

     this._agent = target.cssAgent();
     this._styleLoader = new WebInspector.CSSModel.ComputedStyleLoader(this);
-    target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._mainFrameNavigated, this);
+    resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._mainFrameNavigated, this);
     target.registerCSSDispatcher(new WebInspector.CSSDispatcher(this));
     this._agent.enable().then(this._wasEnabled.bind(this));
     /** @type {!Map.<string, !WebInspector.CSSStyleSheetHeader>} */
     this._styleSheetIdToHeader = new Map();
     /** @type {!Map.<string, !Object.<!PageAgent.FrameId, !Array.<!CSSAgent.StyleSheetId>>>} */
     this._styleSheetIdsForURL = new Map();
 
     /** @type {!Map.<!WebInspector.CSSStyleSheetHeader, !Promise<string>>} */
     this._originalStyleSheetText = new Map();
 
@@ skipping 176 matching lines @@
         if (!this._sourceMapURLToHeaders.has(header.sourceMapURL))
             this._sourceMapByURL.delete(header.sourceMapURL);
         this.dispatchEventToListeners(WebInspector.CSSModel.Events.SourceMapDetached, header);
     },
 
     /**
      * @return {!WebInspector.DOMModel}
      */
     domModel: function()
     {
-        return /** @type {!WebInspector.DOMModel} */(this._domModel);
+        return this._domModel;
     },
 
     /**
+     * @return {!WebInspector.ResourceTreeModel}
+     */
+    resourceTreeModel: function()

[dgozman, 2016/07/22 17:19:43]

Let's not expose it.

[pfeldman, 2016/07/22 17:33:47]

We should not expose one model from another.

[eostroukhov-old, 2016/07/25 19:36:10]

Done.

[eostroukhov-old, 2016/07/25 19:36:10]

Done.

+    {
+        return this._resourceTreeModel;
+    },
+
+    /**
      * @param {!CSSAgent.StyleSheetId} styleSheetId
      * @param {!WebInspector.TextRange} range
      * @param {string} text
      * @param {boolean} majorChange
      * @return {!Promise<boolean>}
      */
     setStyleText: function(styleSheetId, range, text, majorChange)
     {
         var original = this._innerSetStyleTexts.bind(this, [styleSheetId], [range], [text], majorChange);
         var header = this.styleSheetHeaderForId(styleSheetId);
@@ skipping 467 matching lines @@
             return new WebInspector.CSSStyleRule(this, rulePayload);
         }
     },
 
     /**
      * @param {!WebInspector.DOMNode} node
      * @param {function(?WebInspector.CSSStyleSheetHeader)} userCallback
      */
     requestViaInspectorStylesheet: function(node, userCallback)
     {
-        var frameId = node.frameId() || this.target().resourceTreeModel.mainFrame.id;
+        var frameId = node.frameId() || this._resourceTreeModel.mainFrame.id;

[pfeldman, 2016/07/22 17:33:47]

We should instead send frameId along with the root node.

[eostroukhov-old, 2016/07/25 19:36:10]

Done.

         var headers = this._styleSheetIdToHeader.valuesArray();
         for (var i = 0; i < headers.length; ++i) {
             var styleSheetHeader = headers[i];
             if (styleSheetHeader.frameId === frameId && styleSheetHeader.isViaInspector()) {
                 userCallback(styleSheetHeader);
                 return;
             }
         }
 
         /**
@@ skipping 467 matching lines @@
 /**
  * @constructor
  * @param {?WebInspector.CSSStyleDeclaration} inlineStyle
  * @param {?WebInspector.CSSStyleDeclaration} attributesStyle
  */
 WebInspector.CSSModel.InlineStyleResult = function(inlineStyle, attributesStyle)
 {
     this.inlineStyle = inlineStyle;
     this.attributesStyle = attributesStyle;
 }