[DevTools] Explicitly require ResourceTreeModel

third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 698 matching lines @@
     },
 
     /**
      * @override
      */
     tracingComplete: function()
     {
         if (!this._tracingModel)
             return;
         this._tracingModel.tracingComplete();
-        var resourceTreeModel = this._target.resourceTreeModel;
+        var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._target);

[pfeldman, 2016/07/22 17:33:47]

1) WebInspector.NetworkPanel.FilmStripRecorder should only exist for targets
with resource tree. You should pass it in the constructor along with the target.
This is worth a separate CL.

2) We should untangle UI capability that reloads the page from resource tree
model and block it on that level.

[eostroukhov-old, 2016/07/25 19:36:10]

1) Ack, but not addressing here.
2) Routed through the target manager, as per dgozman suggestion below.

         this._target = null;
-        setImmediate(resourceTreeModel.resumeReload.bind(resourceTreeModel));
+        if (resourceTreeModel)
+            setImmediate(resourceTreeModel.resumeReload.bind(resourceTreeModel));
         this._callback(new WebInspector.FilmStripModel(this._tracingModel, this._timeCalculator.minimumBoundary() * 1000));
         delete this._callback;
     },
 
     /**
      * @override
      */
     tracingBufferUsage: function()
     {
     },
@@ skipping 31 matching lines @@
 
     /**
      * @param {function(?WebInspector.FilmStripModel)} callback
      */
     stopRecording: function(callback)
     {
         if (!this._target)
             return;
 
         this._target.tracingManager.stop();
-        this._target.resourceTreeModel.suspendReload();
+        var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._target);
+        if (resourceTreeModel)
+            resourceTreeModel.suspendReload();

[dgozman, 2016/07/22 17:19:43]

Let's proxy suspendReload and resumeReload through TargetManager (as we do with
TargetManager.reloadPage).

[eostroukhov-old, 2016/07/25 19:36:10]

Done - both for the supend and resume.

         this._callback = callback;
         this._filmStripView.setStatusText(WebInspector.UIString("Fetching frames..."));
     }
 }
 
 /**
  * @constructor
  * @implements {WebInspector.ActionDelegate}
  */
 WebInspector.NetworkPanel.RecordActionDelegate = function()
 {
 }
 WebInspector.NetworkPanel.RecordActionDelegate.prototype = {
     /**
      * @override
      * @param {!WebInspector.Context} context
      * @param {string} actionId
      * @return {boolean}
      */
     handleAction: function(context, actionId)
     {
         var panel = WebInspector.context.flavor(WebInspector.NetworkPanel);
         console.assert(panel && panel instanceof WebInspector.NetworkPanel);
         panel._toggleRecording();
         return true;
     }
 }