Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2168313004:
telemetry: Disable top sites in thread_times benchmarks. (Closed)
Descriptiontelemetry: Disable top sites in thread_times benchmarks.
Top sites update tasks add noise to these benchmarks. Disabling
until tasks are converted to use the TaskScheduler APIs.
BUG=588745
BUG=621128
Committed: https://crrev.com/2def4f5e4c629472298fa679b9803d382960a807
Cr-Commit-Position: refs/heads/master@{#407560}
Patch Set 1 #
Messages
Total messages: 26 (10 generated)
Description was changed from ========== telemetry: Disable top sites in thread_times benchmarks. Top sites update tasks add noise to these benchmarks. Disabling until tasks are converted to use the TaskScheduler APIs. BUG=588745 BUG=621128 ========== to ========== telemetry: Disable top sites in thread_times benchmarks. Top sites update tasks add noise to these benchmarks. Disabling until tasks are converted to use the TaskScheduler APIs. BUG=588745 BUG=621128 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
vmiura@chromium.org changed reviewers: + nednguyen@google.com
PTAL
lgtm
The CQ bit was checked by vmiura@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.perf
For more details, see http://crbug.com/617627.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by vmiura@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.perf
For more details, see http://crbug.com/617627.
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use CQ_INCLUDE_TRYBOTS instead.
The CQ bit was unchecked by vmiura@chromium.org
Description was changed from ========== telemetry: Disable top sites in thread_times benchmarks. Top sites update tasks add noise to these benchmarks. Disabling until tasks are converted to use the TaskScheduler APIs. BUG=588745 BUG=621128 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== telemetry: Disable top sites in thread_times benchmarks. Top sites update tasks add noise to these benchmarks. Disabling until tasks are converted to use the TaskScheduler APIs. BUG=588745 BUG=621128 ==========
The CQ bit was checked by vmiura@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== telemetry: Disable top sites in thread_times benchmarks. Top sites update tasks add noise to these benchmarks. Disabling until tasks are converted to use the TaskScheduler APIs. BUG=588745 BUG=621128 ========== to ========== telemetry: Disable top sites in thread_times benchmarks. Top sites update tasks add noise to these benchmarks. Disabling until tasks are converted to use the TaskScheduler APIs. BUG=588745 BUG=621128 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== telemetry: Disable top sites in thread_times benchmarks. Top sites update tasks add noise to these benchmarks. Disabling until tasks are converted to use the TaskScheduler APIs. BUG=588745 BUG=621128 ========== to ========== telemetry: Disable top sites in thread_times benchmarks. Top sites update tasks add noise to these benchmarks. Disabling until tasks are converted to use the TaskScheduler APIs. BUG=588745 BUG=621128 Committed: https://crrev.com/2def4f5e4c629472298fa679b9803d382960a807 Cr-Commit-Position: refs/heads/master@{#407560} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2def4f5e4c629472298fa679b9803d382960a807 Cr-Commit-Position: refs/heads/master@{#407560} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
