Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/py_vulcanize/py_vulcanize/html_module_unittest.py

Issue 2168303002: Fix py_vulcanize tests to use polymer 1.0 (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/py_vulcanize/py_vulcanize/html_module_unittest.py
diff --git a/third_party/py_vulcanize/py_vulcanize/html_module_unittest.py b/third_party/py_vulcanize/py_vulcanize/html_module_unittest.py
index 1931bb582675d77a6121cc8d437119edcd7e54be..828d29b0409243f5d8857098132ff33f1ee62f94 100644
--- a/third_party/py_vulcanize/py_vulcanize/html_module_unittest.py
+++ b/third_party/py_vulcanize/py_vulcanize/html_module_unittest.py
@@ -183,14 +183,14 @@ class HTMLModuleTests(unittest.TestCase):
<link rel="import" href="/widget.html">
<link rel="stylesheet" href="../common.css">
<script src="/raw_script.js"></script>
-<polymer-element name="start">
+<dom-module id="start">
<template>
</template>
<script>
'use strict';
console.log('inline script for start.html got written');
</script>
-</polymer-element>
+</dom-module>
"""
file_contents[os.path.normpath('/py_vulcanize/py_vulcanize.html')] = """<!DOCTYPE html>
"""
@@ -244,7 +244,7 @@ console.log('/raw/raw_script.js was written');
# Check HTML generation.
html = generate.GenerateStandaloneHTMLAsString(
load_sequence, title='', flattened_js_url='/blah.js')
- assert '<polymer-element name="start">' in html
+ assert '<dom-module id="start">' in html
assert 'inline script for widget.html' not in html
assert 'common.css' in html
@@ -252,15 +252,16 @@ console.log('/raw/raw_script.js was written');
file_contents = {}
file_contents[os.path.normpath('/tmp/a/b/my_component.html')] = """
<!DOCTYPE html>
-<polymer-element name="my-component">
+<dom-module id="my-component">
<template>
</template>
<script>
'use strict';
Polymer ( {
+ is: "my-component"
});
</script>
-</polymer-element>
+</dom-module>
"""
with fake_fs.FakeFS(file_contents):
project = project_module.Project([
@@ -276,42 +277,12 @@ console.log('/raw/raw_script.js was written');
js = f.getvalue().rstrip()
expected_js = """
'use strict';
- Polymer ( 'my-component', {
+ Polymer ( {
+ is: "my-component"
});
""".rstrip()
self.assertEquals(expected_js, js)
- def testPolymerConversion2(self):
- file_contents = {}
- file_contents[os.path.normpath('/tmp/a/b/my_component.html')] = """
-<!DOCTYPE html>
-<polymer-element name="my-component">
- <template>
- </template>
- <script>
- 'use strict';
- Polymer ( );
- </script>
-</polymer-element>
-"""
- with fake_fs.FakeFS(file_contents):
- project = project_module.Project([
- os.path.normpath('/py_vulcanize/'), os.path.normpath('/tmp/')])
- loader = resource_loader.ResourceLoader(project)
- my_component = loader.LoadModule(module_name='a.b.my_component')
-
- f = StringIO.StringIO()
- my_component.AppendJSContentsToFile(
- f,
- use_include_tags_for_scripts=False,
- dir_for_include_tag_root=None)
- js = f.getvalue().rstrip()
- expected_js = """
- 'use strict';
- Polymer ( 'my-component');
-""".rstrip()
- self.assertEquals(expected_js, js)
-
def testInlineStylesheetURLs(self):
file_contents = {}
file_contents[os.path.normpath('/tmp/a/b/my_component.html')] = """
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698