Remove redundant Scope book-keeping

Remove redundant Scope book-keeping

The uses_arguments() bool is not needed for correct
behavior, since that same information is available after scope analysis
based on whether we allocated the Scope::arguments_ var.

BUG=v8:5209
Committed: https://crrev.com/f77d1bfc367055f49f492548dec610337fb59b53
Cr-Commit-Position: refs/heads/master@{#37990}

[adamk, 2016-07-22 00:09:16]

adamk@chromium.org changed reviewers:
+ littledan@chromium.org, verwaest@chromium.org

[adamk, 2016-07-22 00:09:20]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 00:09:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-07-22 00:09:54]

adamk@chromium.org changed reviewers:
+ marja@chromium.org

[commit-bot: I haz the power, 2016-07-22 00:27:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 00:27:37]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[marja, 2016-07-22 07:22:50]

Some relevant tests seem to fail. Otherwise the code LG but looks like we can't
remove all of that...

[adamk, 2016-07-22 18:26:24]

On 2016/07/22 07:22:50, marja wrote:
> Some relevant tests seem to fail. Otherwise the code LG but looks like we
can't
> remove all of that...

Ah, OK, now I see what that uses_super_property bool is for:

```js
// Flags: --min-preparse-length=0
var object = {
  a() { return 'a' + super.m(); },
};
print(object.a());
```

it's _only_ needed on Scopes during preparsing...will think of what to do here.

[adamk, 2016-07-22 23:09:11]

Description was changed from

==========
Remove redundant Scope book-keeping

Neither uses_super_property() nor uses_arguments() is needed for correct
behavior, since that same information is available after scope analysis
(based on whether we allocated a this_function_var_ or an arguments_ var,
respectively).

This reduces PropagateUsageFlagsToScope() to a single call, which I've
inlined into the two callers, and removes two bool members from Scope.

BUG=v8:5209
==========

to

==========
Remove redundant Scope book-keeping

The uses_arguments() bool is not needed for correct
behavior, since that same information is available after scope analysis
based on whether we allocated the Scope::arguments_ var.

BUG=v8:5209
==========

[adamk, 2016-07-22 23:10:25]

Updated to leave super properties as-is: we need that bit during lazy parsing so
that we know to install [[HomeObject]] on lazy-parsed and lazy-compiled methods
etc.

[adamk, 2016-07-22 23:10:43]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 23:10:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 23:33:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 23:33:41]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-07-22 23:44:03]

lgtm

[adamk, 2016-07-22 23:46:33]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-07-22 23:46:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 23:48:22]

Description was changed from

==========
Remove redundant Scope book-keeping

The uses_arguments() bool is not needed for correct
behavior, since that same information is available after scope analysis
based on whether we allocated the Scope::arguments_ var.

BUG=v8:5209
==========

to

==========
Remove redundant Scope book-keeping

The uses_arguments() bool is not needed for correct
behavior, since that same information is available after scope analysis
based on whether we allocated the Scope::arguments_ var.

BUG=v8:5209
==========

[commit-bot: I haz the power, 2016-07-22 23:48:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 23:51:00]

Description was changed from

==========
Remove redundant Scope book-keeping

The uses_arguments() bool is not needed for correct
behavior, since that same information is available after scope analysis
based on whether we allocated the Scope::arguments_ var.

BUG=v8:5209
==========

to

==========
Remove redundant Scope book-keeping

The uses_arguments() bool is not needed for correct
behavior, since that same information is available after scope analysis
based on whether we allocated the Scope::arguments_ var.

BUG=v8:5209

Committed: https://crrev.com/f77d1bfc367055f49f492548dec610337fb59b53
Cr-Commit-Position: refs/heads/master@{#37990}
==========

[commit-bot: I haz the power, 2016-07-22 23:51:01]

Patchset 2 (id:??) landed as
https://crrev.com/f77d1bfc367055f49f492548dec610337fb59b53
Cr-Commit-Position: refs/heads/master@{#37990}